From owner-cvs-all Wed Jan 19 22:50:24 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 0E12115392 for ; Wed, 19 Jan 2000 22:50:18 -0800 (PST) (envelope-from bde@zeta.org.au) Received: (qmail 28003 invoked from network); 20 Jan 2000 06:50:11 -0000 Received: from bde.zeta.org.au (203.2.228.102) by gidora.zeta.org.au with SMTP; 20 Jan 2000 06:50:11 -0000 Date: Thu, 20 Jan 2000 17:50:09 +1100 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Alfred Perlstein Cc: Jason Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_aio.c In-Reply-To: <20000119210539.F20191@fw.wintelcom.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Wed, 19 Jan 2000, Alfred Perlstein wrote: > * Jason Evans [000119 18:23] wrote: > > jasone 2000/01/19 18:00:00 PST > > > > Modified files: > > sys/kern vfs_aio.c > > Log: > > Don't tsleep() while at splbio(). > > Unless it fixes some other bug, sleeping with spl raised is perfectly valid. And usually necessary to avoid races (Locking 101, part 3: an spl is not a lock...). However, it may not be necessary in vfs_aio.c, since the wakeups may only come from other processes and not from interrupt handlers. vfs_aio.c sleeps outside of an spl'ed section in about 6 other places, including 2 in very similar code. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message