From owner-freebsd-current Sun Dec 21 18:10:57 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id SAA16628 for current-outgoing; Sun, 21 Dec 1997 18:10:57 -0800 (PST) (envelope-from owner-freebsd-current) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id SAA16621 for ; Sun, 21 Dec 1997 18:10:51 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id TAA15935; Sun, 21 Dec 1997 19:10:43 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id TAA27576; Sun, 21 Dec 1997 19:10:40 -0700 Date: Sun, 21 Dec 1997 19:10:40 -0700 Message-Id: <199712220210.TAA27576@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Greg Lehey Cc: Joerg Wunsch , freebsd-current@freebsd.org Subject: Re: Bruce vandalism again In-Reply-To: <19971222101914.28785@lemis.com> References: <199712201434.JAA00329@dyson.iquest.net> <14545.882642903@time.cdrom.com> <19971221120534.43478@lemis.com> <199712211002.LAA00388@uriah.heep.sax.de> <19971222101914.28785@lemis.com> X-Mailer: VM 6.29 under 19.15 XEmacs Lucid Sender: owner-freebsd-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > Self-consistency, inside one file. > > So far, so good. But the question of consistency brings with it the > question of what kind of consistency. Specifically, do we want to > advance or retreat? Converting a file for the sake of converting a file isn't 'advancing't the state of the art. White-space changes for the sake of white-space changes aren't doing anybody any good. However, having said that, in the pccard userland code, I've been slowly changing the style/format of the file over time. It is now almost completely ANSI, mostly because I'm maintaining the code. Since I'm maintaining the code, I felt it would help *ME* do my job better, and since I prefer ANSI prototypes it wasn't a wasted effort. revision 1.6 date: 1996/06/18 23:50:51; author: nate; state: Exp; lines: +36 -64 Staticize and removed unused code. ---------------------------- revision 1.5 date: 1996/06/18 19:52:29; author: nate; state: Exp; lines: +34 -232 - Removed dead code (if you need it you can get it out of the Repository). - Added some comments, and moved some code around to make flow more obvious. No functional changes. ---------------------------- revision 1.4 date: 1996/04/18 04:25:13; author: nate; state: Exp; lines: +25 -1 Added RCS Id and BSD-style copyrights to individual files. ---------------------------- revision 1.3 date: 1996/04/10 06:49:30; author: nate; state: Exp; lines: +360 -413 Run indent on all these files to make them more readable. (I also went through by hand and cleaned up some indent bogons.) ---------------------------- However, changing files just to change them makes no sense to me, because it's not helping anyone. Basically, if you can't understand the code just because it uses K&R prototypes, then changing them to use ANSI prototypes 'just to use ANSI prototypes' is silliness. > > It's quite normal that if your definition is old-style, the > > declaration would still be prototyped on a compiler that defines > > __STDC__ (via __P()). > > If the programmer does the Right Thing. My understanding was that > style(9) discourages __P(). No, style(9) encourarges file consistency, which is *still* the primary argument. Bruce changed some files that Julian modified to be self-consistant, and Julian objected to it. Self-consistancy *was* and continues to be the real issue. > > Mixed declaration styles inside the same file have never been > > encouraged. > > No debate about that. Actually, that is the crux of the original matter. Nate