From owner-cvs-all  Thu Nov 18 10:14:36 1999
Delivered-To: cvs-all@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 67D2E154A7; Thu, 18 Nov 1999 10:14:20 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.3/8.9.1) id KAA86275;
	Thu, 18 Nov 1999 10:14:11 -0800 (PST)
	(envelope-from dillon)
Date: Thu, 18 Nov 1999 10:14:11 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199911181814.KAA86275@apollo.backplane.com>
To: Nick Hibma <hibma@skylink.it>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c vfs_vnops.c
References:  <Pine.BSF.3.96.991118152128.342J-100000@henny.jrc.it>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk


:
:
:
:>   PR:		kern/14966
:>   Reviewed by:	dillon@freebsd.org
:>   Submitted by:	Kelly Yancey kbyanc@posi.net
:
:This sounds like you commit someone else's patches, reviewed by a third
:person, without reviewing them yourself. But you don't. If you commit
:something than you are supposed to review the code beforehand.
:
:So the 'Reviewed by' is unneccessary. 
:
:Nick

    I don't consider a simple PR reference to be proper credit, so I
    put Kelly's name in the Submitted by: field (since he did submit it),
    and since I reviewed it I put my name in the Reviewed by: field.
    Sounds right to me.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message