Date: 14 Dec 1997 20:22:48 +0100 From: Eivind Eklund <perhaps@yes.no> To: freebsd-hackers@FreeBSD.ORG Subject: Re: New option model (was Re: cvs commit: src/sys/kern kern_exit.c) Message-ID: <86zpm3pw53.fsf@bitbox.follo.net> In-Reply-To: j@uriah.heep.sax.de's message of Sun, 14 Dec 1997 19:16:08 %2B0100 (MET) References: <199712071816.KAA21840@freefall.freebsd.org> <19971208091729.40125@uriah.heep.sax.de> <863ek4p1tx.fsf_-_@bitbox.follo.net> <199712100013.BAA04827@uriah.heep.sax.de> <863ek1xtsl.fsf@bitbox.follo.net> <199712141816.TAA29536@uriah.heep.sax.de>
next in thread | previous in thread | raw e-mail | index | archive | help
j@uriah.heep.sax.de (J Wunsch) writes: > Eivind Eklund <perhaps@yes.no> wrote: > > > As far as I can see, the only correct #ifdef's in the kernel .c files > > are #ifdef KERNEL (should be _KERNEL) - everything else should be > > #if to allow #define XXX 1 or 0. Am I correct? Should I fix this as > > I do my walkthrough anyway? > > Hmm, not sure. All the boolean current options are #ifdef-evaluated. > > What do others think about it? I don't see an urgent need to change > _this_. I didn't notice all of those options had an 'N' prefixed :-( NPPP_DEFLATE still seems somehow bogus. Fixing the non-header file versions would then just be adding the proper opt_xxx.h includes - should be trivial, except I'm not certain what kernel code is being re-vamped at any moment. > Well, if you were going to spell _KERNEL correctly, by all means, go > ahead! ;) Won't this break many patches people are keeping externally? > I'm not sure what others think about kernel structs that vary their > size based on different kernel option usage. IMHO they should die, > since they are highly dangerous, and this danger doesn't justify the > few saved bytes. I dislike them, at least. <DIVERSION>I also dislike using structs to communicate kernel <-> userland - e.g. for ipfw. I'd like this to use something like the tags system on the Amiga.</DIVERSION> Eivind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zpm3pw53.fsf>