From owner-freebsd-hackers@freebsd.org Thu May 19 04:14:32 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8922FB41324 for ; Thu, 19 May 2016 04:14:32 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 6FC3E1FD9 for ; Thu, 19 May 2016 04:14:32 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 4E9C9DE32 for ; Thu, 19 May 2016 04:14:31 +0000 (UTC) Subject: Re: What changes are welcome? To: freebsd-hackers@freebsd.org References: <20160519041118.GE19887@gmail.com> From: Allan Jude Message-ID: <573D3DA7.20600@freebsd.org> Date: Thu, 19 May 2016 00:14:31 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160519041118.GE19887@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 04:14:32 -0000 On 2016-05-19 00:11, Randy Westlund wrote: > I'd like to start contributing to the base system, but I need > clarification on what sort of changes would be welcome. > > I thought I'd start on simple compiler warnings. The top code in > /contrib/top, for example uses K&R-style function definitions and > implicit return types that spews -Wimplicit-int and -Wreturn-type > warnings. > > While I'm silencing those, is it appropriate for me to make the file > follow style(9)? > > Once I have a diff, should I just upload it to bugzilla, or is it > preferable to put it on phabricator and then link to it from bugzilla? > > Randy > Generally, you likely want to avoid changing anything from contrib/ or vendor/, as that is code from other projects that is imported, and local changes complicate that. Of course, top is not really maintained 'upstream' anymore, so maybe it isn't a bad place to start. Phabricator is likely the best place for patches, it is much easier to review. -- Allan Jude