From owner-p4-projects@FreeBSD.ORG Fri Mar 31 20:36:50 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 8079516A427; Fri, 31 Mar 2006 20:36:50 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46DD516A426 for ; Fri, 31 Mar 2006 20:36:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47F2943D48 for ; Fri, 31 Mar 2006 20:36:49 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k2VKajRC016651; Fri, 31 Mar 2006 15:36:47 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Marcel Moolenaar Date: Fri, 31 Mar 2006 15:37:24 -0500 User-Agent: KMail/1.9.1 References: <200603302348.k2UNmDJd096792@repoman.freebsd.org> <200603310851.42196.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603311537.26612.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1364/Thu Mar 30 15:05:50 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 94334 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2006 20:36:50 -0000 On Friday 31 March 2006 12:37, Marcel Moolenaar wrote: > > On Mar 31, 2006, at 5:51 AM, John Baldwin wrote: > > > On Thursday 30 March 2006 06:48 pm, Marcel Moolenaar wrote: > >> http://perforce.freebsd.org/chv.cgi?CH=94334 > >> > >> Change 94334 by marcel@marcel_nfs on 2006/03/30 23:47:36 > >> > >> Strip-down puc(4): > >> o Remove PUC_PORT_TYPE_UART: we always use uart(4) now, so we > >> can use PUC_PORT_TYPE_COM for that. > >> o Remove PUC_PORT_UART_*: we don't support UART sub-types. All > >> UARTs are standard ns8250 again. > >> o Remove PUC_FLAGS_MEMORY and PUC_FLAGS_ALTRES: we try I/O ports > >> first and if that fails, we try memory. > >> o Remove PUC_FASTINTR: we try setting up a fast handler first, > >> and if that fails we try a MPSAFE one. > > > > Unfortunately that algorithm doesn't work in the case of a shared > > interrupt > > if puc is the first device to attach. The other devices then just > > "lose". > > It's the standard algorithm I use. I expect the platform to either > share a fast interrupt handler with a non-fast handler or silently > downgrade my fast handler to a mpsafe one if later events demand > this. All I can indicate in my driver is what I'm capable of. The > MD interrupt code should do what needs to be done based on that > and the surrounding environment and subsequent events. I have no > visibility over and/or knowledge about that and cannot program > for it then. None of the platforms have ever done the downgrade thing FWIW. Only ppc doesn't share INTR_FAST now, so I think you could probably just always use INTR_FAST. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org