From owner-freebsd-bugs  Sun Dec 10 22:50: 6 2000
From owner-freebsd-bugs@FreeBSD.ORG  Sun Dec 10 22:50:01 2000
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 3BEBB37B401
	for <freebsd-bugs@hub.freebsd.org>; Sun, 10 Dec 2000 22:50:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id eBB6o1Y27203;
	Sun, 10 Dec 2000 22:50:01 -0800 (PST)
	(envelope-from gnats)
Resent-Date: Sun, 10 Dec 2000 22:50:01 -0800 (PST)
Resent-Message-Id: <200012110650.eBB6o1Y27203@freefall.freebsd.org>
Resent-From: gnats-admin@FreeBSD.org (GNATS Management)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: gnats-admin@FreeBSD.org, yasu@mrit.mei.co.jp
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4A92E37B699
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Dec 2000 22:40:11 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id eBB6eBZ26190;
	Sun, 10 Dec 2000 22:40:11 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200012110640.eBB6eBZ26190@freefall.freebsd.org>
Date: Sun, 10 Dec 2000 22:40:11 -0800 (PST)
From: yasu@mrit.mei.co.jp
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: kern/23457: typeo in kern_sig.c
Resent-Sender: gnats@FreeBSD.org
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         23457
>Category:       kern
>Synopsis:       typeo in kern_sig.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 10 22:50:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Yasuhiko Watanabe
>Release:        4.1-STABLE
>Organization:
Matsushita Research Institute Tokyo, Inc.
>Environment:
>Description:
kern_sig.c was fully rewritten due to new sigset_t types around Sep. 1999. (between rev 1.64 to 1.65) There seems suspicous typo in trapsignal().

-	mask = sigmask(signum);
-	if ((p->p_flag & P_TRACED) == 0 && (p->p_sigcatch & mask) != 0 &&
-	    (p->p_sigmask & mask) == 0) {
+	if ((p->p_flag & P_TRACED) == 0 && SIGISMEMBER(p->p_sigcatch, sig) &&
+	    SIGISMEMBER(p->p_sigmask, sig)) {
 		p->p_stats->p_ru.ru_nsignals++;
I guess the last condition in if statement should be !SIGMEMBER(p->p_sigmask, sig) instead of SIGMEMBER(p->p_sigmask, sig)


>How-To-Repeat:

>Fix:
need a ! before the last SIGMEMBER()


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message