From owner-svn-src-head@FreeBSD.ORG  Fri Feb 24 09:38:07 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id C31151065673; Fri, 24 Feb 2012 09:38:07 +0000 (UTC)
Date: Fri, 24 Feb 2012 09:38:07 +0000
From: Alexander Best <arundel@freebsd.org>
To: Dimitry Andric <dim@FreeBSD.org>
Message-ID: <20120224093807.GA88853@freebsd.org>
References: <201202232134.q1NLYEq5024067@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201202232134.q1NLYEq5024067@svn.freebsd.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r232074 - head/sys/cam/ctl
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2012 09:38:07 -0000

On Thu Feb 23 12, Dimitry Andric wrote:
> Author: dim
> Date: Thu Feb 23 21:34:14 2012
> New Revision: 232074
> URL: http://svn.freebsd.org/changeset/base/232074
> 
> Log:
>   Use a better way to silence unneeded internal declaration warnings in
>   several sys/cam/ctl files.

is the clang version in base able to do complete universe builds for i386 and
amd64 without the need for NO_WERROR= and WERROR= now?

cheers.
alex

ps: are there any plans to add support for compiling kernel+userland with clang
tot? maybe this can be accomplished by doing something like

echo "WITH_CLANG_TOT=yes" >> /etc/src.conf

which will turn all -Wformat-invalid-specifier and -Wformat-extra-args errors
into warnings (because clang tot doesn't support -fformat-extensions)?


>   
>   Suggested by:	ed
>   Reviewed by:	ken
>   MFC after:	1 week
> 
> Modified:
>   head/sys/cam/ctl/ctl_private.h
> 
> Modified: head/sys/cam/ctl/ctl_private.h
> ==============================================================================
> --- head/sys/cam/ctl/ctl_private.h	Thu Feb 23 21:32:32 2012	(r232073)
> +++ head/sys/cam/ctl/ctl_private.h	Thu Feb 23 21:34:14 2012	(r232074)
> @@ -297,7 +297,7 @@ struct ctl_page_index {
>  #define	CTL_PAGE_DEFAULT	0x02
>  #define	CTL_PAGE_SAVED		0x03
>  
> -static struct ctl_page_index page_index_template[] = {
> +static const struct ctl_page_index page_index_template[] = {
>  	{SMS_FORMAT_DEVICE_PAGE, 0, sizeof(struct scsi_format_page), NULL,
>  	 CTL_PAGE_FLAG_DISK_ONLY, NULL, NULL},
>  	{SMS_RIGID_DISK_PAGE, 0, sizeof(struct scsi_rigid_disk_page), NULL,