Date: Tue, 09 Aug 2022 08:25:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 265651] [NEW PORT] archivers/zpaqfranz: versioned/snapshot archive Message-ID: <bug-265651-7788-JCpI4AIHit@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-265651-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-265651-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265651 Felix Palmen <zirias@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zirias@freebsd.org --- Comment #1 from Felix Palmen <zirias@freebsd.org> --- Thanks for submitting a port! A few things require changes though: * Never set WRKSRC to WRKDIR. Instead, for an upstream distfile that doesn't create a subdir itself, set NO_WRKSUBDIR=3Dyes. * Never define do-build and do-install targes if upstream already provides a build system that can do them (which is the case here). * Always remove -march=3Dnative (you will need to patch the upstream Makefi= le for that). Packages must only contain generic binary code that works on every machine. * Similar for CPU features, you're checking for SSE2 on the building machin= e, but if the executing machine doesn't have it, it will fail. In general, you can't assume SSE2 on i386. * The upstream Makefile installs the same binary twice. Remove one of them.= If the second name is really strictly needed, replace it with a symlink. --- A simple fixed port could look like this: 1) remove everything in the port Makefile starting with WRKSRC=3D ... Inste= ad just use this: NO_WRKSUBDIR=3D yes CFLAGS+=3D -DNOJIT 2) add a local patch for upstream's Makefile, removing the -march=3Dnatice = and also the second install command. If necessary replace it with a symlink, e.= g. like this: ln -s zpaqfranz ${DESTDIR}${BINDIR}/dir --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265651-7788-JCpI4AIHit>