Date: Mon, 21 Jul 2008 10:33:39 +0200 From: "Antoine Brodin" <antoine@FreeBSD.org> To: "Garrett Cooper" <yanefbsd@gmail.com> Cc: freebsd-bugs@freebsd.org Subject: Re: bin/125680: atacontrol(8): atacontrol depends on executable in /usr Message-ID: <f19c444a0807210133m3f057089id8dcc5017488df43@mail.gmail.com> In-Reply-To: <7d6fde3d0807210104t188b6ab5hc61dc67c49d27188@mail.gmail.com> References: <200807202210.m6KMA4cm032331@freefall.freebsd.org> <7d6fde3d0807201714g49eb4a80ncfcc1cc800ad595e@mail.gmail.com> <f19c444a0807210039v99e8701g6c9c1fcb4f3e7b5@mail.gmail.com> <7d6fde3d0807210104t188b6ab5hc61dc67c49d27188@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_91012_9625174.1216629219724
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
On Mon, Jul 21, 2008 at 10:04 AM, Garrett Cooper <yanefbsd@gmail.com> wrote:
> Antoine,
> You're right. I flip-flopped parent and child there in my
> original statement.
> I also saw the async ('&') terminal command.
> But what is ultimately gained by forking another process to read
> a device other than just resuming control for the terminal to the
> user? It seems like all this does is create potential for additional
> zombie processes on the system...
> Just as an experiment, could you insert another printf or some
> statement to ensure that the read is deterministically completed every
> time?
I have attached a patch with an extra printf.
I guess that the dd/read is done in the background because it can take
hours, so the user doesn't have to wait hours to have his terminal
back.
Cheers,
Antoine
------=_Part_91012_9625174.1216629219724
Content-Type: text/plain; name=atacontrol2-diff.txt
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fiwtfvsn0
Content-Disposition: attachment; filename=atacontrol2-diff.txt
SW5kZXg6IHNiaW4vYXRhY29udHJvbC9hdGFjb250cm9sLmMKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog
L2hvbWUvbmN2cy9zcmMvc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuYyx2CnJldHJpZXZpbmcg
cmV2aXNpb24gMS40OApkaWZmIC11IC1wIC1yMS40OCBhdGFjb250cm9sLmMKLS0tIHNiaW4vYXRh
Y29udHJvbC9hdGFjb250cm9sLmMJMTUgTWF5IDIwMDggMDE6MjU6MjkgLTAwMDAJMS40OAorKysg
c2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuYwkyMSBKdWwgMjAwOCAwODoxOTo0NiAtMDAwMApA
QCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgPHN0cmluZy5o
PgogI2luY2x1ZGUgPHN5c2V4aXRzLmg+CisjaW5jbHVkZSA8dW5pc3RkLmg+CiAKIHN0YXRpYyBj
b25zdCBjaGFyICoKIG1vZGUyc3RyKGludCBtb2RlKQpAQCAtNTE3LDEyICs1MTgsMzEgQEAgbWFp
bihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAJCWlmIChpb2N0bChmZCwgSU9DQVRBUkFJRFJFQlVJ
TEQsICZhcnJheSkgPCAwKQogCQkJd2FybigiaW9jdGwoSU9DQVRBUkFJRFJFQlVJTEQpIik7CiAJ
CWVsc2UgewotCQkJY2hhciBidWZmZXJbMTI4XTsKLQkJCXNwcmludGYoYnVmZmVyLCAiL3Vzci9i
aW4vbmljZSAtbiAyMCAvYmluL2RkICIKLQkJCQkiaWY9L2Rldi9hciVkIG9mPS9kZXYvbnVsbCBi
cz0xbSAmIiwKLQkJCQlhcnJheSk7Ci0JCQlpZiAoc3lzdGVtKGJ1ZmZlcikpCi0JCQkJd2Fybigi
YmFja2dyb3VuZCBkZCIpOworCQkJY2hhciBkZXZpY2VbNjRdOworCQkJY2hhciAqYnVmZmVyOwor
CQkJaW50IGFyZmQ7CisKKwkJCXN3aXRjaCAoZm9yaygpKSB7CisJCQljYXNlIC0xOgorCQkJCWVy
cigxLCAiZm9yayIpOworCQkJY2FzZSAwOgorCQkJCW5pY2UoMjApOworCQkJCXNucHJpbnRmKGRl
dmljZSwgc2l6ZW9mKGRldmljZSksICIvZGV2L2FyJWQiLAorCQkJCQlhcnJheSk7CisJCQkJaWYg
KChhcmZkID0gb3BlbihkZXZpY2UsIE9fUkRPTkxZKSkgPT0gLTEpCisJCQkJCWVycigxLCAib3Bl
biAlcyIsIGRldmljZSk7CisJCQkJaWYgKChidWZmZXIgPSBtYWxsb2MoMTAyNCAqIDEwMjQpKSA9
PSBOVUxMKQorCQkJCQllcnIoMSwgIm1hbGxvYyIpOworCQkJCXdoaWxlIChyZWFkKGFyZmQsIGJ1
ZmZlciwgMTAyNCAqIDEwMjQpID4gMCkKKwkJCQkJOworCQkJCXByaW50ZigiYXRhY29udHJvbDog
YXIlZCByZWJ1aWxkIGNvbXBsZXRlZFxuIiwKKwkJCQkJYXJyYXkpOworCQkJCWZyZWUoYnVmZmVy
KTsKKwkJCQljbG9zZShhcmZkKTsKKwkJCQlicmVhazsKKwkJCWRlZmF1bHQ6CisJCQkJYnJlYWs7
CisJCQl9CiAJCX0KIAkJZXhpdChFWF9PSyk7CiAJfQo=
------=_Part_91012_9625174.1216629219724--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f19c444a0807210133m3f057089id8dcc5017488df43>