Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Sep 2016 14:35:40 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 212745] chinese/ydict: update port to new version and to use github
Message-ID:  <bug-212745-13-ai5r6lAJeD@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-212745-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-212745-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212745

John Marino <marino@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino@FreeBSD.org

--- Comment #1 from John Marino <marino@FreeBSD.org> ---
patch has issues

1) there's no new distfile
2) GH_PROJECT line is redundant
3) it's a new version, there should be a poudriere or synth log to prove the
pkg-plist is still good and there are no other stage-qa issues
4) it should contain the WWW changes, not have a separate PR for that.

As is, this patch can't be accepted.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-212745-13-ai5r6lAJeD>