From owner-freebsd-net@freebsd.org Mon Feb 3 23:02:56 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53F722324DB for ; Mon, 3 Feb 2020 23:02:56 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670058.outbound.protection.outlook.com [40.107.67.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48BNdq1hSQz4H21 for ; Mon, 3 Feb 2020 23:02:54 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZt5Za87VxPsT3KRASDte7e4Jf+42zm7vwr+EbuHkyAk+BVYvxP8qhQ5L9mkuix8Y2amBRejcB/wL34+8NQ0HH+V5LUqT/biLOw7jElK91EBV166Qea0a01K8iA/Ie9VpNKKK5ImRXROTrCLB7QTV4K1AWNUkjwbROljcG/fipa0J3VjbZvQclbaar5OdoIdZTdKR6MX4Rwq+GGGV7apNedjgPtM08r1dMNWlFmM5HhdM52XRRq06BszxOzle+Hd4ALf3iR6rBzOoWnlYp2bYZWZcqEQyjQF8G9s1c5YVYEk050LvlQ1vvyFj2BIQGNlEG4G50h35Nx73bv639wAgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8E83K6xN0N4ouCzrv7EjJLOYy2/takfrEhymHRWRkRk=; b=aQfTYPZy8SKrSkpjJCleGRYRYr5aqU0wfHuZ949br6WZyXyAWeAwxSrdBnE07B8q1TY6GoYQswZSBcgB+hcUa4gvQPtW9DRZhs1xFIlBdtuWiuFHeJUxbdJdWrSpJZ+EwHae4coll9MzbOzTy+B5Pu/BAE/wAPhAWnFTl9Ll/QWcvebONsygWsnjMIewvGiAPFVSC9KanyXyRCQ6YIRY8tOIHvB52cSTiCuiPo1oYiscszYZIdGl3SABFcH2qv3/S78EeJS9Kkoli4/q65u/AoWH7YWLYT2x1hWLpAyo1wBdLcwluWPSHz4MDMq2uIeW5SfIXDvfVR0vnoATsk6odw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM (10.255.46.82) by YTBPR01MB3902.CANPRD01.PROD.OUTLOOK.COM (10.255.47.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.30; Mon, 3 Feb 2020 23:02:54 +0000 Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4]) by YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4%3]) with mapi id 15.20.2686.031; Mon, 3 Feb 2020 23:02:53 +0000 From: Rick Macklem To: Hans Petter Selasky , freebsd-net Subject: Re: Does sosend() need CURVNET_SET/CURVNET_RESTORE? Thread-Topic: Does sosend() need CURVNET_SET/CURVNET_RESTORE? Thread-Index: AQHV2g6GHsgkYI39oUK5ywsAZhXoO6gIbKiAgAGqfno= Date: Mon, 3 Feb 2020 23:02:53 +0000 Message-ID: References: , <6ba3e3bd-d844-e685-7062-339e57438748@selasky.org> In-Reply-To: <6ba3e3bd-d844-e685-7062-339e57438748@selasky.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b4d3444-f19f-412f-4516-08d7a8fd3377 x-ms-traffictypediagnostic: YTBPR01MB3902: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0302D4F392 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(136003)(376002)(39860400002)(396003)(189003)(199004)(4744005)(316002)(786003)(110136005)(6506007)(8936002)(26005)(478600001)(86362001)(186003)(8676002)(2906002)(33656002)(66446008)(71200400001)(91956017)(64756008)(66556008)(76116006)(81156014)(81166006)(7696005)(66946007)(55016002)(9686003)(66476007)(5660300002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB3902; H:YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n0VVkSLs6DaNao+Ec2wOqANYuKhKCV80PtYugWdAIl939YpVyL5isgZjBV5m4v2HMk7a/PnFgHsH4ODlFTP092Soe8Is0SToLrn9/kbzFaRBr9tYkq68p+9340t2j6HKnc2AnYm29fD0u/rqmWneIJepmb7kf4/kn40+amsFRD0Hzv96Nvy3kH0aarIjBkNEJNtGzMNv18Rf09ICRywiyd62MNDhhNgcINXgO/IU0hL7DAVVtITsbYvbNTKBUYaSrp0kEEx4yx02mmXqTLe+oYmrsxaaE7JIkt+J4RGXhX30dI5xggVWFJ7vUkh2iMRQgVziI8yY/ltaEqP+tmYLPd5Aw3iI9MgD7a2CgZ0QYcKoKgyfYmPAXaYtxL+3r8GHSF8t1jSUgC+/hWQB4pjTr8AE1jfI+YcwLINh+zAQ/er2WtRhih75SaJkT3rHjiXB x-ms-exchange-antispam-messagedata: Qg8LszJeER4D74VvEjR7kLeMDG916Nte+UCQV8jFOirZAlbpLJG8Pe52WrDREdPVdypeW8k0dISonRBEag02U/8LishLys1COVr8YwiBceWYiJQnAFhjyT4V7foC1bnoNuLFlBMi3T1WhutMaYwjig== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4d3444-f19f-412f-4516-08d7a8fd3377 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 23:02:53.8901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0IMWKgyiYTtyhDnkCjylPS+UsueQNf1VviCawlDd+DaO/bNdQSQyExxh+6pUQsBRk9le9AELjj2z3+jnVmZg/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB3902 X-Rspamd-Queue-Id: 48BNdq1hSQz4H21 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.58 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.70 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[58.67.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.40)[ipnet: 40.64.0.0/10(-3.86), asn: 8075(-3.07), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2020 23:02:56 -0000 Hans Petter Selasky wrote:=0A= >On 2020-02-02 22:22, Rick Macklem wrote:=0A= >> Hi,=0A= >>=0A= >> The current krpc code calls sosend() and soreceive() without any=0A= >> CURVNET_SET()/CURVNET_RESTORE() wrapped around them.=0A= >>=0A= >> When I recently used sosend_generic(), it panic'd without them.=0A= >>=0A= >> Do they need to be added around sosend()/soreceive()?=0A= >>=0A= >> I'll admit to knowing nothing about vnet.=0A= >>=0A= >> Thanks, rick=0A= >=0A= >What is the panic backtrace?=0A= I'd have to do it again to find out...=0A= =0A= >Usually one of these tree variants is used:=0A= >=0A= >CURVNET_SET(TD_TO_VNET(td));=0A= >CURVNET_SET(ifp->if_vnet);=0A= >CURVNET_SET(so->so_vnet);=0A= I got rid of the panic by adding the third one, which is what I now see=0A= sosend() uses.=0A= However, if sosend() is calling sosend_generic(), I'll just call sosend(),= =0A= which takes care of it.=0A= =0A= Thanks for your help, rick=0A= =0A= --HPS=0A= =0A= =0A=