Date: Wed, 14 Oct 1998 21:29:36 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: David Greenman <dg@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/i386/i386 busdma_machdep.c vm_machdep.c src/sys/i386/ibcs2 imgact_coff.c src/sys/i386/include param.h src/sys/i386/isa isa.c wd.c src/sys/kern imgact_elf.c sys_pipe.c sysv_shm.c vfs_bio.c ... Message-ID: <Pine.BSF.4.01.9810142128170.389-100000@herring.nlsystems.com> In-Reply-To: <199810130824.BAA23019@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 13 Oct 1998, David Greenman wrote: > dg 1998/10/13 01:24:45 PDT > > Modified files: > sys/cam/scsi scsi_da.c > sys/i386/i386 busdma_machdep.c vm_machdep.c > sys/i386/ibcs2 imgact_coff.c > sys/i386/include param.h > sys/i386/isa isa.c wd.c > sys/kern imgact_elf.c sys_pipe.c sysv_shm.c > vfs_bio.c vfs_subr.c > sys/vm default_pager.c device_pager.c > swap_pager.c vm_glue.c vm_map.c vm_mmap.c > vm_pager.c vm_pager.h vm_unix.c > vnode_pager.c vnode_pager.h > Log: > Fixed two potentially serious classes of bugs: > > 1) The vnode pager wasn't properly tracking the file size due to > "size" being page rounded in some cases and not in others. > This sometimes resulted in corrupted files. First noticed by > Terry Lambert. > Fixed by changing the "size" pager_alloc parameter to be a 64bit > byte value (as opposed to a 32bit page index) and changing the > pagers and their callers to deal with this properly. > 2) Fixed a bogus type cast in round_page() and trunc_page() that > caused some 64bit offsets and sizes to be scrambled. Removing > the cast required adding casts at a few dozen callers. > There may be problems with other bogus casts in close-by > macros. A quick check seemed to indicate that those were okay, > however. Do I need to track this change in the alpha port? Can you give me a rough idea of the changes to busdma_machdep.c, vm_machdep.c and param.h so that I can make the appropriate change (if needed). -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9810142128170.389-100000>