From owner-freebsd-current@FreeBSD.ORG Fri Jun 29 13:19:58 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFAC3106564A; Fri, 29 Jun 2012 13:19:58 +0000 (UTC) (envelope-from jbeich@tormail.org) Received: from server2.allsitecontrol.com (server2.allsitecontrol.com [63.143.36.210]) by mx1.freebsd.org (Postfix) with ESMTP id 7309B8FC0A; Fri, 29 Jun 2012 13:19:58 +0000 (UTC) Received: from tor20.anonymizer.ccc.de ([31.172.30.3]:39068 helo=internal.tormail.org) by server2.allsitecontrol.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.77) (envelope-from ) id 1SkYzK-002t8J-98; Fri, 29 Jun 2012 07:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tormail.org; s=tm; h=Message-Id:X-TorMail-User:Content-Type:MIME-Version:References:Date:In-Reply-To:Subject:Cc:To:From; bh=2iNMBWz1J7koQQFjd6/wR/UQybpI6su7zV7+ORHa9XQ=; b=dGAteT/fmOFtvBAeStL2N7zXTbX0nmBDsKbDmd+jVnO+sx+eH1C9z8QnRD8d2vYu38pjZSWHlb8GapEUk/wWecM1DDcEh1SUmWRRG1SIaOwMGG9ul2oTOjVDaD3R2D+0HtUeec4iX4d4OeusasB1xyQ5+7+BqAFXkB1kUfir4jg=; Received: from jbeich by internal.tormail.org with local (Exim 4.63) (envelope-from ) id 1SkYxx-0007Fr-SA; Fri, 29 Jun 2012 11:02:22 +0000 From: Jan Beich To: Dimitry Andric In-Reply-To: <4FEB5B0E.8020009@FreeBSD.org> (Dimitry Andric's message of "Wed, 27 Jun 2012 21:12:14 +0200") Date: Fri, 29 Jun 2012 06:01:48 -0500 References: <4FE9B01C.30306@yandex.ru> <4FEB5B0E.8020009@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-TorMail-User: jbeich Message-Id: <1SkYxx-0007Fr-SA@internal.tormail.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server2.allsitecontrol.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tormail.org X-Source: X-Source-Args: X-Source-Dir: X-Mailman-Approved-At: Fri, 29 Jun 2012 13:35:25 +0000 Cc: freebsd-current Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 13:19:58 -0000 Dimitry Andric writes: > On 2012-06-26 14:50, Andrey V. Elsukov wrote: > >> Some time ago i have started reading the code in the sys/boot. >> Especially i'm interested in the partition tables handling. >> I found several problems: >> 1. There are several copies of the same code in the libi386/biosdisk.c >> and common/disk.c, and partially libpc98/biosdisk.c. >> 2. ZFS probing is very slow, because the ZFS code doesn't know how many >> disks and partitions the system has: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=148296 >> http://www.freebsd.org/cgi/query-pr.cgi?pr=161897 >> 3. The GPT support doesn't check CRC and even doesn't know anything >> about the secondary GPT header/table. >> >> So, i have created the branch and committed the changes: >> http://svnweb.freebsd.org/base/user/ae/bootcode/ >> The patch is here: >> http://people.freebsd.org/~ae/boot.diff > > FWIW, I verified it compiles OK with clang, and especially boot2's size > isn't increased at all. Does it boot for you? Same if I build zfs.c with gcc -O0: FreeBSD/x86 ZFS enabled bootstrap loader, Revision 1.1 (foo@bar, Tue Jun 26 18:52:52 UTC 2012) ZFS: can't find pool by guid ZFS: can't find pool by guid can't load 'kernel' > > It would be nice if you could check it with clang now and again, before > you finally merge this project into head.