From owner-freebsd-bugs  Wed Dec 12 14:30: 9 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4007037B41C
	for <freebsd-bugs@hub.freebsd.org>; Wed, 12 Dec 2001 14:30:06 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fBCMU6W93819;
	Wed, 12 Dec 2001 14:30:06 -0800 (PST)
	(envelope-from gnats)
Date: Wed, 12 Dec 2001 14:30:06 -0800 (PST)
Message-Id: <200112122230.fBCMU6W93819@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Will Andrews <will@csociety.org>
Subject: Re: misc/32680: [PATCH] Allows users to start jails by hostname as well as IP address
Reply-To: Will Andrews <will@csociety.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR misc/32680; it has been noted by GNATS.

From: Will Andrews <will@csociety.org>
To: Evan Sarmiento <evms@cs.bu.edu>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/32680: [PATCH] Allows users to start jails by hostname as well as IP address
Date: Wed, 12 Dec 2001 17:27:42 -0500

 On Mon, Dec 10, 2001 at 11:27:58AM -0800, Evan Sarmiento wrote:
 > --- jail.c.orig Sun Jun 24 16:28:19 2001
 > +++ jail.c      Mon Dec 10 14:21:19 2001
 [...]
 > @@ -40,14 +40,26 @@
 [...]
 > -       if (!i)
 > -               errx(1, "Couldn't make sense of ip-number\n");
 > +
 > +       if (!i) {
 > +         hp = gethostbyname(argv[3]);
 > +
 > +         if (hp == NULL)
 > +          errx(1, "gethostbyname(%s): %s (and) inet_aton(%s): Could not
 > +           make sense of ip-number", argv[3], hstrerror(h_errno), argv[3] );
 > +
 > +         else if (hp)
 > +          in = *(struct in_addr *)hp->h_addr;
 > +
 > +        }
 > +
 
 style(9) says:
 
      Indentation is an 8 character tab.  Second level indents are four spaces.
      If you have to wrap a long statement, put the operator at the end of the
      line.
 
 > -               err(1, "Imprisonment failed");
 > +         err(1, "Imprisonment failed");
 >         i = execv(argv[4], argv + 4);
 >         if (i)
 > -               err(1, "execv(%s)", argv[4]);
 > +         err(1, "execv(%s)", argv[4]);
 > +
 >         exit (0);
 
 Whitespace changes.
 
 -- 
 wca

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message