From owner-freebsd-scsi@FreeBSD.ORG  Wed Jul 18 18:11:45 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD4BD1065679
	for <freebsd-scsi@freebsd.org>; Wed, 18 Jul 2012 18:11:45 +0000 (UTC)
	(envelope-from seanbru@yahoo-inc.com)
Received: from mrout2-b.corp.bf1.yahoo.com (mrout2-b.corp.bf1.yahoo.com
	[98.139.253.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 743BD8FC18
	for <freebsd-scsi@freebsd.org>; Wed, 18 Jul 2012 18:11:45 +0000 (UTC)
Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231])
	by mrout2-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id
	q6IIB87a093459; Wed, 18 Jul 2012 11:11:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com;
	s=cobra; t=1342635069;
	bh=SRpt2kecnXLdCgfSHKxI+H/N15H1q1WsA8Y0JITYm+c=;
	h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:
	Message-ID:Mime-Version:Content-Transfer-Encoding;
	b=hjdF84o8HvMMyxDg003hKIWtcguAn5152t0KdXPn7tpXozKSTL+xeyjnIkpeTmHty
	R+mmlnbthUk8oTM8CRI71KMjaWcj/b/QiyMqDqZa0vIdsD2XVpH0wtvXZA/DHcZMW8
	HD/U7WcbkHjcfNZb3xzRSXjdFSoR8Gk0C7QMtdOA=
From: Sean Bruno <seanbru@yahoo-inc.com>
To: Mark Johnston <markjdb@gmail.com>
In-Reply-To: <20120713223720.GA51989@oddish.sandvine.com>
References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com>
	<1341340916.3370.6.camel@powernoodle.corp.yahoo.com>
	<2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com>
	<1341938629.2573.7.camel@powernoodle.corp.yahoo.com>
	<1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com>
	<20120713223720.GA51989@oddish.sandvine.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 18 Jul 2012 11:11:08 -0700
Message-ID: <1342635068.2924.4.camel@powernoodle.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
X-Milter-Version: master.31+4-gbc07cd5+
X-CLX-ID: 635068003
Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>,
	Scott Long <scott4long@yahoo.com>
Subject: Re: [patch] MFI should set bio_resid on command failure
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jul 2012 18:11:45 -0000

On Fri, 2012-07-13 at 15:37 -0700, Mark Johnston wrote:
> It seems that the analogous line is also missing from aac(4). Is the
> patch below correct? Or am I missing something?
> 
> Thanks,
> -Mark
> 
> diff --git a/sys/dev/aac/aac_disk.c b/sys/dev/aac/aac_disk.c
> index e4042f7..f2f6636 100644
> --- a/sys/dev/aac/aac_disk.c
> +++ b/sys/dev/aac/aac_disk.c
> @@ -334,8 +334,10 @@ aac_biodone(struct bio *bp)
>  {
>         fwprintf(NULL, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
>  
> -       if (bp->bio_flags & BIO_ERROR)
> +       if (bp->bio_flags & BIO_ERROR) {
> +               bp->bio_resid = bp->bio_bcount;
>                 disk_err(bp, "hard error", -1, 1);
> +       }
>  
>         biodone(bp);
>  } 

Committed at svn r238601

Sean