From owner-cvs-all@FreeBSD.ORG  Mon Mar 21 16:56:06 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C466D16A4CE; Mon, 21 Mar 2005 16:56:06 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 76C2543D41; Mon, 21 Mar 2005 16:56:06 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] (sam@[66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2LGu5ms034857
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 21 Mar 2005 08:56:06 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <423EFD0C.1060708@errno.com>
Date: Mon, 21 Mar 2005 08:57:48 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Giorgos Keramidas <keramida@FreeBSD.org>
References: <200503211636.j2LGa5Xx054701@repoman.freebsd.org>
	<20050321165143.GA3842@orion.daedalusnetworks.priv>
In-Reply-To: <20050321165143.GA3842@orion.daedalusnetworks.priv>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pstat Makefile pstat.8 pstat.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2005 16:56:06 -0000

Giorgos Keramidas wrote:
> On 2005-03-21 16:36, Giorgos Keramidas <keramida@freebsd.org> wrote:
> 
>>  Revision  Changes    Path
>>  1.13      +2 -2      src/usr.sbin/pstat/Makefile
>>  1.47      +8 -3      src/usr.sbin/pstat/pstat.8
>>  1.93      +40 -19    src/usr.sbin/pstat/pstat.c
> 
> 
> This is still WARNS=2 clean, as the previous pstat version.
> 
> The following change makes pstat WARNS=3 clean in i386, sparc64 and
> amd64.  Are we allowed to use C99 constructs like the ones shown below
> in userlevel code?
> 
> %%%
> Index: pstat.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/pstat/pstat.c,v
> retrieving revision 1.93
> diff -u -r1.93 pstat.c
> --- pstat.c	21 Mar 2005 16:36:05 -0000	1.93
> +++ pstat.c	21 Mar 2005 16:42:45 -0000
> @@ -81,11 +81,11 @@
>  };
>  
>  static struct nlist nl[] = {
> -	{ "_constty", 0 },
> -	{ "_maxfiles", 0 },
> -	{ "_nfiles", 0 },
> -	{ "_tty_list", 0 },
> -	{ "" }
> +	{ .n_name = "_constty" },
> +	{ .n_name = "_maxfiles" },
> +	{ .n_name = "_nfiles" },
> +	{ .n_name = "_tty_list" },
> +	{ .n_name = "" }
>  };
>  
>  static int	humanflag;
> %%%
> 
> 
ifconfig uses them and noone's slapped me (yet) :)

	Sam