From owner-freebsd-rc@FreeBSD.ORG Sun Jun 10 04:33:05 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id AD4341065670 for ; Sun, 10 Jun 2012 04:33:05 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 67D821518F6; Sun, 10 Jun 2012 04:33:05 +0000 (UTC) Message-ID: <4FD42381.5080504@FreeBSD.org> Date: Sat, 09 Jun 2012 21:33:05 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120609 Thunderbird/13.0 MIME-Version: 1.0 To: Sahil Tandon References: <20120609010405.GA295@magic.hamla.org> <4FD38ED0.7070803@FreeBSD.org> <20120610040657.GA1415@magic.hamla.org> In-Reply-To: <20120610040657.GA1415@magic.hamla.org> X-Enigmail-Version: 1.4.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: RESEND: [sahil@tandon.net: Request for review: mail/postfix-postfwd rc script] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2012 04:33:05 -0000 On 06/09/2012 21:06, Sahil Tandon wrote: >> 7. With pidfile= the check command you added should not be necessary, >> 'service postfwd status' is what you want instead. > > That does not work, because of the peculiarities of this program: > looking for its procname (with or without interpreter) is futile because > the ps output shows '[perl5.10.1]' rather than something more useful. :( Ah, it's that one ... no worries then. >> Of course, none of this is tested, so you'll want to do that. :) >> ... > > One thing I retained is start_precmd, which is needed because of an > upstream bug (I've reported it) which causes the program to silently > terminate if 'start' is issued when postfwd is already running! Let me > know if there is a more suitable way to handle this until it is fixed > upstream. That actually shouldn't happen ... service named start named already running? (pid=843). If you have pidfile defined properly the check you're using should be handled by rc.subr already. Doug -- This .signature sanitized for your protection