From owner-freebsd-amd64@FreeBSD.ORG Thu Jul 12 12:40:04 2012 Return-Path: Delivered-To: freebsd-amd64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 424731065687 for ; Thu, 12 Jul 2012 12:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 102EF8FC18 for ; Thu, 12 Jul 2012 12:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6CCe3CP030061 for ; Thu, 12 Jul 2012 12:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6CCe3oS030060; Thu, 12 Jul 2012 12:40:03 GMT (envelope-from gnats) Date: Thu, 12 Jul 2012 12:40:03 GMT Message-Id: <201207121240.q6CCe3oS030060@freefall.freebsd.org> To: freebsd-amd64@FreeBSD.org From: John Baldwin Cc: Subject: Re: amd64/169779: [patch] powerd doesn't honor the -n flag X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Baldwin List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 12:40:04 -0000 The following reply was made to PR amd64/169779; it has been noted by GNATS. From: John Baldwin To: freebsd-amd64@freebsd.org Cc: Axel Gonzalez , freebsd-gnats-submit@freebsd.org, acpi@freebsd.org Subject: Re: amd64/169779: [patch] powerd doesn't honor the -n flag Date: Thu, 12 Jul 2012 07:40:09 -0400 On Tuesday, July 10, 2012 10:48:51 pm Axel Gonzalez wrote: > > >Number: 169779 > >Category: amd64 > >Synopsis: [patch] powerd doesn't honor the -n flag > >Confidential: no > >Severity: serious > >Priority: low > >Responsible: freebsd-amd64 > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: sw-bug > >Submitter-Id: current-users > >Arrival-Date: Wed Jul 11 02:50:10 UTC 2012 > >Closed-Date: > >Last-Modified: > >Originator: Axel Gonzalez > >Release: 9.0-RELEASE-p2 > >Organization: > >Environment: > FreeBSD moonlight 9.0-RELEASE-p2 FreeBSD 9.0-RELEASE-p2 #0: Tue Jun 12 02:12:57 CDT 2012 toor@moonlight:/usr/obj/usr/src/sys/LXCORE964 amd64 > >Description: > powerd never initializes the variable that keeps the status of the line status. This variable defaults to 0 (with the compiler? with the arch?) and results in powerd using the AC profile. > > This is a problem, since at start it says it is in unkown status, but doesn't respect the -n argument. > > Note: since the variable is not initialized, it can lead to other unexpected behaviour. > > >How-To-Repeat: > This should use the "adaptive" profile specified by -n, but uses hiadaptive > > # /usr/sbin/powerd -i 50 -r 80 -M 1800 -v -p 1000 -n adaptive > powerd: unable to determine AC line status > CPU frequency is above user-defined maximum; changing frequency to 1795 MHz > load 15%, current freq 1795 MHz ( 0), wanted freq 2094 MHz > > >Fix: > Initialize the variable > > --- powerd.c.orig 2012-07-10 21:21:07.882970887 -0500 > +++ powerd.c 2012-07-10 21:22:29.292974203 -0500 > @@ -278,6 +278,7 @@ > acline_init(void) > { > acline_mib_len = 4; > + acline_status = SRC_UNKNOWN; > > if (sysctlnametomib(ACPIAC, acline_mib, &acline_mib_len) == 0) { > acline_mode = ac_sysctl; I suspect this is correct, but cc'ing acpi@ to see if anyone there has any comments. -- John Baldwin