Date: Wed, 21 Oct 1998 02:59:28 -0700 From: "David O'Brien" <obrien@nuxi.com> To: Peter Wemm <peter@netplex.com.au> Cc: cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/stdio mktemp.c Message-ID: <19981021025928.A21068@nuxi.com> In-Reply-To: <199810210231.KAA14549@spinner.netplex.com.au>; from Peter Wemm on Wed, Oct 21, 1998 at 10:31:05AM %2B0800 References: <199810202134.PAA28899@harmony.village.org> <199810210231.KAA14549@spinner.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> - open(path, O_CREAT|O_EXCL|O_RDWR, 0600)) >= 0) > + open(path, O_CREAT|O_EXCL|O_RDWR, 0600)) >= 0) { Stylistically speaking, why do people keep insisting on not checking error conditions properly? open(2) is documented to return "-1" on error, not non-negative as many want to test it against. Yes, this has caused me problems on an old 286 Xenix system. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19981021025928.A21068>