From owner-cvs-all  Thu Jun 11 08:53:24 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id IAA15271
          for cvs-all-outgoing; Thu, 11 Jun 1998 08:53:24 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA15248;
          Thu, 11 Jun 1998 08:53:13 -0700 (PDT)
          (envelope-from julian@whistle.com)
Received: (from daemon@localhost)
	by alpo.whistle.com (8.8.5/8.8.5) id IAA29061;
	Thu, 11 Jun 1998 08:47:35 -0700 (PDT)
Received: from current1.whistle.com(207.76.205.22)
 via SMTP by alpo.whistle.com, id smtpd029058; Thu Jun 11 15:47:26 1998
Date: Thu, 11 Jun 1998 08:47:23 -0700 (PDT)
From: Julian Elischer <julian@whistle.com>
To: Peter Wemm <peter@netplex.com.au>
cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.ORG,
        julian@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vnops.c 
In-Reply-To: <199806110550.NAA10253@spinner.netplex.com.au>
Message-ID: <Pine.BSF.3.95.980611084605.29233B-100000@current1.whistle.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

I committed the fix as suplied by kirk.
It was only as I was half way throught the commit message that I realised
that it reversed the other commit (as the major part of a bigger fix)

On Thu, 11 Jun 1998, Peter Wemm wrote:

> Julian Elischer wrote:
> > And your point is?
> 
> While I'm slightly shocked to be agreeing with Bruce on a pedantic issue
> for a change :-),  this really should have been done as two commits.  The
> first should have been the backout of rev 1.46, the second should have been
> the other changes you made, including some sort of nutshell description of
> what was done.  It's a heck of a lot easier to figure out what's going on
> that way.
> 
> > On Thu, 11 Jun 1998, Bruce Evans wrote:
> > 
> > > >  Modified files:
> > > >    sys/ufs/ffs          ffs_vnops.c 
> > > >  Log:
> > > >  Back out John's changes 1.45 -> 1.46
> > > >  Kirk confirms that the original semantic was what he wanted...
> > > >  (well, a very slight difference)
> > > >  May fix "dangling deps" panic with soft updates.
> > > >  
> > > >  Revision  Changes    Path
> > > >  1.50      +17 -21    src/sys/ufs/ffs/ffs_vnops.c
> > > 
> > > A back out would have been +12 -17.
> > > 
> > > It also seems to change the semantic to "wait for v_numoutput even in
> > > the soft updates case", and fix some style bugs, and break the
> > > optimization of using vfs_bio_awrite() instead of bawrite() for async
> > > writes of indirect blocks.
> > > 
> > > Bruce
> > > 
> > 
> 
> Cheers,
> -Peter
> --
> Peter Wemm <peter@netplex.com.au>   Netplex Consulting
> 
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message