From owner-freebsd-arch@FreeBSD.ORG Thu May 3 04:08:29 2007 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9778416A401; Thu, 3 May 2007 04:08:29 +0000 (UTC) (envelope-from sean-freebsd@farley.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id 61CDC13C448; Thu, 3 May 2007 04:08:29 +0000 (UTC) (envelope-from sean-freebsd@farley.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l4349w7u076550; Wed, 2 May 2007 23:09:59 -0500 (CDT) (envelope-from sean-freebsd@farley.org) Date: Wed, 2 May 2007 23:08:18 -0500 (CDT) From: "Sean C. Farley" To: Daniel Eischen In-Reply-To: Message-ID: <20070502230413.Y30614@thor.farley.org> References: <20070501083009.GA4627@nagual.pp.ru> <20070501160645.GA9333@nagual.pp.ru> <20070501135439.B36275@thor.farley.org> <20070502.102822.-957833022.imp@bsdimp.com> <20070502183100.P1317@baba.farley.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: arch@freebsd.org Subject: Re: HEADS DOWN X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 04:08:29 -0000 On Wed, 2 May 2007, Daniel Eischen wrote: > On Wed, 2 May 2007, Sean C. Farley wrote: >> 2. getenv() sets errno to EINVAL and returns NULL if given a bad name >> to find. setenv() and unsetenv() perform the same check on the >> name; should not getenv() do the same? The check is easy to >> remove. > > I don't think getenv() should set errno. The fact that it > returns NULL is sufficient and POSIX doesn't define any errors > for it. Fixed for errno. Also, no value is appropriate for errno when the name does not exist. How about the feature that getenv() returns a NULL for a bad name instead of allowing a core dump? Is that acceptable? Sean -- sean-freebsd@farley.org