Date: Fri, 29 Jun 2012 13:27:26 -0400 From: George Neville-Neil <gnn@neville-neil.com> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: Mark Peek <mp@FreeBSD.org>, freebsd-current@FreeBSD.org, pfg@freebsd.org Subject: Re: [RFT] llquantize for FreeBSD's dtrace Message-ID: <5993D573-4D53-44F5-BE8F-C48E9816398B@neville-neil.com> In-Reply-To: <20120626210606.632498e2@fabiankeil.de> References: <4FE9EFF9.9080507@FreeBSD.org> <1340735734.53528.YahooMailClassic@web113510.mail.gq1.yahoo.com> <20120626210606.632498e2@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 26, 2012, at 15:06 , Fabian Keil wrote: > Pedro Giffuni <pfg@freebsd.org> wrote: > >> --- Mar 26/6/12, Mark Peek <mp@FreeBSD.org> ha scritto: > >>> Try this, change the assert on line 1429 in file dt_cc.c >>> from: >>> >>> assert(!(arg & (UINT16_MAX << args[i].shift))); >>> >>> to >>> >>> assert(!(arg & ((uint64_t)UINT16_MAX << >>> args[i].shift))); >>> >> >> This certainly looks correct. Thanks Mark ! >> >> I updated the patch: >> >> http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize > > Thanks a lot. Seems to work for me: > And me as well. I tested the example from the web site. Nicely done! Best, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5993D573-4D53-44F5-BE8F-C48E9816398B>