From owner-freebsd-jail@FreeBSD.ORG  Thu Jun  6 16:47:17 2013
Return-Path: <owner-freebsd-jail@FreeBSD.ORG>
Delivered-To: freebsd-jail@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 1A36CEEC;
 Thu,  6 Jun 2013 16:47:17 +0000 (UTC) (envelope-from nvass@gmx.com)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20])
 by mx1.freebsd.org (Postfix) with ESMTP id A7C0F1D9A;
 Thu,  6 Jun 2013 16:47:16 +0000 (UTC)
Received: from [172.31.0.42] ([85.216.121.245]) by mail.gmx.com (mrgmx001)
 with ESMTPSA (Nemesis) id 0M6ilI-1UPe5B3EJQ-00wXDy; Thu, 06 Jun 2013 18:47:10
 +0200
Message-ID: <51B0BD05.60102@gmx.com>
Date: Thu, 06 Jun 2013 18:47:01 +0200
From: Nikos Vassiliadis <nvass@gmx.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:17.0) Gecko/20130329 Thunderbird/17.0.5
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: pf + vimage patch
References: <51AC84EE.6020009@gmx.com> <20130605085219.GA53217@gmail.com>
 <51B065F5.4080209@gmx.com> <20130606122409.GA10459@gmail.com>
 <20130606122855.GC14667@glebius.int.ru>
In-Reply-To: <20130606122855.GC14667@glebius.int.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:yLPARyYTKHkkRyMtMbsVYPXLJmfa+iUwAGfyu/gWFigeoljAbek
 VURb4qnVbCeCSutaraVeR5+cQsGY6dqwta+KHp2Lhpkc6jc+4Ns8Ov8aCm9ARWdepLnqwvq
 j/Z9aJIJ/x21zUjY5JgwGE1dA4TOgBZeCHVhGulJQH3SYRQNvT0LpyINMl/H+xpcFUBVc0s
 jHUNEiKxYm0gHLIptgxGQ==
Cc: Mikolaj Golub <trociny@FreeBSD.org>, "Bjoern A. Zeeb" <bz@FreeBSD.org>,
 freebsd-jail@freebsd.org, freebsd-virtualization@freebsd.org,
 freebsd-pf@freebsd.org
X-BeenThere: freebsd-jail@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion about FreeBSD jail\(8\)" <freebsd-jail.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-jail>,
 <mailto:freebsd-jail-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-jail>
List-Post: <mailto:freebsd-jail@freebsd.org>
List-Help: <mailto:freebsd-jail-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-jail>,
 <mailto:freebsd-jail-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jun 2013 16:47:17 -0000

On 06/06/2013 02:28 PM, Gleb Smirnoff wrote:
> M> > module unload is broken:( Maybe it can be fixed at a (bit) later date?
> M>
> M> I don't think Gleb will be happy with this. Some time ago he removed
> M> some vimage related stuff to prevent crashing on module unload (see
> M> r229849). Actually your patch looks like a partial revert of that
> M> commit. So I think you need to think about this issue from start. At
> M> least it should not crash non-vimage kernel and there should be
> M> understanding how to fix it for vimage kernel. Your approach with
> M> keeping only one purge thread might make it simpler.

Unloading should be simple in the non-vimage case as well - I think.

> True. It is very much appreciated that you are working on vimage + pf,
> but breaking module unload isn't an option.
>
> When hacking on a part of kernel, having a possibility to avoid a reboot
> after each compile is very important.
>

Good point. Thank you both for your comments.

Nikos