Date: Sun, 24 Mar 2019 18:51:13 -0600 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: Rebecca Cran <rebecca@bluestop.org>, Konstantin Belousov <kostikbel@gmail.com>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, "freebsd-arch@freebsd.org" <arch@freebsd.org> Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" Message-ID: <CANCZdfrHrHcgYnY4nCHQSr5Yxd_7605NzvWBWDtC7hJ-fYcuqg@mail.gmail.com> In-Reply-To: <CEADFA63-9086-4EC6-A204-2A49254741B0@gmail.com> References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> <20190324090103.GO1923@kib.kiev.ua> <e6695237-6a22-3ff0-b113-9efeee05a51a@bluestop.org> <CANCZdfq1vb2-R-R4AZyoqi_940GCooMuhXyjCgSkHSusic5p_w@mail.gmail.com> <5cda4bb9-c10e-2b44-65db-5a9f29f498d8@bluestop.org> <CEADFA63-9086-4EC6-A204-2A49254741B0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 24, 2019, 6:32 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > On Mar 24, 2019, at 17:20, Rebecca Cran via freebsd-hackers < > freebsd-hackers@freebsd.org> wrote: > > > >> On 3/24/19 5:57 PM, Warner Losh wrote: > >> > >> > >> He's asking for stopping doing a make install in src/stand. I'm > thinking that's a good thing. We should update the ESP's > \efi\freebsd\loader.efi, but leave the\efi\boot\bootXXXX.efi alone as par= t > of this new installloader phase. Again, only if the ESP is mounted, and w= e > have a default spot for it. For this script, I don't think hunting for th= e > ESP is the right way to go... which means we need to define a standard > place for the ESP to be mounted, which we should do before we turn on any > of these features. > >> > >> We have the start of a generic script to update things in > src/tools/boot/install-boot.sh which was supposed to install boot blocks = on > everything known to run FreeBSD. > > > > > > Only updating \efi\freebsd\loader.efi is the wrong thing to do in my > opinion: there are situations like on ARM where EFI variables aren't > persistent, and we need \efi\boot\bootxxxx.efi for booting. What we could > do is check if QueryVariableInfo returns EFI_UNSUPPORTED, in which case w= e > know any changes to BootXXXX variables won't survive a reboot, and we nee= d > BOOTxxxx.efi. > > > > Is it safe to assume there's only a single ESP in the system? Is it not > normal for there to be one ESP per disk for mirrored configurations, in > which case each would need to be updated? > > > > Do you envision src/tools/boot/install-boot.sh moving to /usr/sbin, or > remaining where it is? We'd also need to update the ESP for binary instal= ls > using freebsd-update. > > I was wondering about builds from scratch, as well=E2=80=94images com= pletely > lacking boot blocks like Jenkins builds. > You wouldn't run installloader on those. It's also a reason I don't want to guess too much... Warner > Thanks! > -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrHrHcgYnY4nCHQSr5Yxd_7605NzvWBWDtC7hJ-fYcuqg>