From owner-freebsd-arch Tue Nov 27 8: 2:18 2001 Delivered-To: freebsd-arch@freebsd.org Received: from smtp.bsdhome.com (rdu25-2-113.nc.rr.com [24.25.2.113]) by hub.freebsd.org (Postfix) with ESMTP id 63BF737B417 for ; Tue, 27 Nov 2001 08:02:14 -0800 (PST) Received: from neutrino.bsdhome.com (jupiter [192.168.220.13]) by smtp.bsdhome.com (8.11.3nb1/8.11.4) with ESMTP id fARG2C716719; Tue, 27 Nov 2001 11:02:12 -0500 (EST) Received: (from bsd@localhost) by neutrino.bsdhome.com (8.11.6/8.11.6) id fARG27q20819; Tue, 27 Nov 2001 11:02:07 -0500 (EST) (envelope-from bsd) Date: Tue, 27 Nov 2001 11:02:07 -0500 From: Brian Dean To: John De Boskey Cc: Arch List Subject: Re: Comments on kern/32106 (MAXSHELLCMDLEN increase) Message-ID: <20011127110207.A4106@neutrino.bsdhome.com> References: <20011125183344.A1257@FreeBSD.org> <20011126203106.A450@bsdwins.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011126203106.A450@bsdwins.com>; from jwd@bsdwins.com on Mon, Nov 26, 2001 at 08:31:06PM -0500 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Nov 26, 2001 at 08:31:06PM -0500, John De Boskey wrote: > > 3 small patches can be found at: > > http://people.freebsd.org/~jwd/execve/execve.patch > > and are included below. Please let me know if you see > any major problems. > > -John Looks ok to me. The only thing that I can think of that may be of concern is increasing the command length results in additional kernel stack space being required, which is probably why it is fairly small to begin with. The PR had 512 which is probably way too much for a stack allocated variable. Making this variable allocate dynamic storage is probably not a good idea either for performance reasons. While increasing to 128 adds an additional 64 bytes to what is already required, it seems like a reasonable compromise. -Brian -- Brian Dean bsd@FreeBSD.org bsd@bsdhome.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message