From owner-svn-ports-all@FreeBSD.ORG Tue Feb 17 09:16:21 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1C68DCEF; Tue, 17 Feb 2015 09:16:21 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E582E33C; Tue, 17 Feb 2015 09:16:20 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id DF7FD43BA6; Tue, 17 Feb 2015 03:16:06 -0600 (CST) Message-ID: <54E306CD.9020102@marino.st> Date: Tue, 17 Feb 2015 10:15:57 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Alexey Dokuchaev , "Vanilla I. Shu" Subject: Re: svn commit: r379069 - head/sysutils/shlock References: <201502160749.t1G7nUhH066516@svn.freebsd.org> <20150217090530.GA41942@FreeBSD.org> In-Reply-To: <20150217090530.GA41942@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 09:16:21 -0000 On 2/17/2015 10:05, Alexey Dokuchaev wrote: > On Mon, Feb 16, 2015 at 07:49:30AM +0000, Vanilla I. Shu wrote: >> New Revision: 379069 >> URL: https://svnweb.freebsd.org/changeset/ports/379069 >> QAT: https://qat.redports.org/buildarchive/r379069/ >> >> Log: >> Upgrade to 2.5.4. >> >> PR: 197456 >> Submitted by: Ports Fury. >> [...] >> -PLIST_FILES= bin/${PORTNAME} man/man1/${PORTNAME}.1.gz >> +PLIST_FILES= bin/shlock man/man1/shlock.1.gz > > Gratuitous change that has nothing to do with version upgrade. Maybe not, but it's a good change. Any time the port will break if the PORTNAME changes, this kind of change should be made. disclaimer: using ${PORTNAME} like that is a pet peeve of mine. >> @@ -1,5 +1,5 @@ >> -The historical, and still very useful process-locking program. Use to make >> -sure that your shell script is the only version of itself running on your >> -system. There are many other creative ways to use this program. >> +The historical, and still very useful process-locking program. Use to >> +make sure that your shell script is the only version of itself running >> +on your system. There are many other creative ways to use this program. > > Ditto. Please do not cause repochurn. Kato's PRs are full of this shit. Had these lines been over 75 characters, I would not have agreed. We should be wrapping at 75. I do this fairly often myself. However, the original pkg-descr was already wrapped at 75. We can't get too wrapped around the axle on unmaintained ports for aesthetic changes. That said, I've seen a few "downgrades" from tkato myself, recently the conversion of multi-line single commands with multiple arguments to a loop of commands with one argument. John