From owner-freebsd-bugs@FreeBSD.ORG  Sat Sep 17 15:20:11 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 93CE616A41F
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 17 Sep 2005 15:20:11 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 519DE43D5A
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 17 Sep 2005 15:20:05 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8HFK5T1081498
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 17 Sep 2005 15:20:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8HFK5E1081497;
	Sat, 17 Sep 2005 15:20:05 GMT (envelope-from gnats)
Resent-Date: Sat, 17 Sep 2005 15:20:05 GMT
Resent-Message-Id: <200509171520.j8HFK5E1081497@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	hiroshi oota <ghelp@excite.co.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E704916A41F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 17 Sep 2005 15:17:49 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B7AA743D46
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 17 Sep 2005 15:17:49 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFHnET038871
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 17 Sep 2005 15:17:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j8HFHnt4038870;
	Sat, 17 Sep 2005 15:17:49 GMT (envelope-from nobody)
Message-Id: <200509171517.j8HFHnt4038870@www.freebsd.org>
Date: Sat, 17 Sep 2005 15:17:49 GMT
From: hiroshi oota <ghelp@excite.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: kern/86258: wrong expression in sys/netgraph/ng_pppoe.c
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Sep 2005 15:20:12 -0000


>Number:         86258
>Category:       kern
>Synopsis:       wrong expression in sys/netgraph/ng_pppoe.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 17 15:20:04 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     hiroshi oota
>Release:        7.0-CURRENT
>Organization:
>Environment:
FreeBSD  7.0-CURRENT FreeBSD 7.0-CURRENT #21: Thu Sep  8 08:17:21 UTC 2005 i386

>Description:
A strange conditional expression is in sys/netgraph/ng_pppoe.c. 
Probably, it is a mistake.

enum state {
    PPPOE_SNONE=0,      /* [both] Initial state */
....
                       if (sp->state |= PPPOE_SNONE) { 
>How-To-Repeat:

>Fix:
--- sys/netgraph/ng_pppoe.c.orig        Fri Jul  8 15:11:43 2005
+++ sys/netgraph/ng_pppoe.c     Sat Sep 17 13:43:32 2005
@@ -720,7 +720,7 @@
                        if (msg->header.cmd == NGM_PPPOE_SERVICE) {
                                break;
                        }
-                       if (sp->state |= PPPOE_SNONE) {
+                       if (sp->state != PPPOE_SNONE) {
                                printf("pppoe: Session already active\n");
                                LEAVE(EISCONN);
                        }

>Release-Note:
>Audit-Trail:
>Unformatted: