From owner-cvs-all Wed Oct 4 19:49:53 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 4002437B502; Wed, 4 Oct 2000 19:49:50 -0700 (PDT) Received: (from kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id TAA46160; Wed, 4 Oct 2000 19:49:50 -0700 (PDT) (envelope-from kris@FreeBSD.org) Message-Id: <200010050249.TAA46160@freefall.freebsd.org> From: Kris Kennaway Date: Wed, 4 Oct 2000 19:49:49 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/contrib/tcpdump addrtoname.c print-atalk.c print-bgp.c print-fr.c print-icmp.c print-rx.c print-sunrpc.c print-telnet.c smbutil.c util.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG kris 2000/10/04 19:49:49 PDT Modified files: contrib/tcpdump addrtoname.c print-atalk.c print-bgp.c print-fr.c print-icmp.c print-rx.c print-sunrpc.c print-telnet.c smbutil.c util.c Log: * Buffer-safe string function cleanup. There are a couple of strcpy() and strcat()s which would be more difficult to fix, but I think they're safe anyway. * Don't crash at runtime by overflowing a buffer with constant data in print-icmp.c on a long hostname. * Don't overflow a static buffer by trying to decode an AFS ACL into a buffer which is way too small for it. Reviewed by: -audit Revision Changes Path 1.8 +4 -4 src/contrib/tcpdump/addrtoname.c 1.8 +3 -3 src/contrib/tcpdump/print-atalk.c 1.2 +8 -6 src/contrib/tcpdump/print-bgp.c 1.3 +4 -2 src/contrib/tcpdump/print-fr.c 1.5 +20 -20 src/contrib/tcpdump/print-icmp.c 1.2 +19 -11 src/contrib/tcpdump/print-rx.c 1.6 +5 -3 src/contrib/tcpdump/print-sunrpc.c 1.2 +4 -2 src/contrib/tcpdump/print-telnet.c 1.2 +5 -3 src/contrib/tcpdump/smbutil.c 1.2 +63 -72 src/contrib/tcpdump/util.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message