From owner-cvs-all Sun Aug 23 00:44:25 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA09838 for cvs-all-outgoing; Sun, 23 Aug 1998 00:44:25 -0700 (PDT) (envelope-from owner-cvs-all) Received: from vader.cs.berkeley.edu (vader.CS.Berkeley.EDU [128.32.38.234]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA09833; Sun, 23 Aug 1998 00:44:20 -0700 (PDT) (envelope-from asami@vader.cs.berkeley.edu) Received: from silvia.hip.berkeley.edu (sji-ca10-63.ix.netcom.com [205.186.214.63]) by vader.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id AAA18565; Sun, 23 Aug 1998 00:43:36 -0700 (PDT) Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.8.8/8.6.9) id AAA20430; Sun, 23 Aug 1998 00:43:33 -0700 (PDT) Date: Sun, 23 Aug 1998 00:43:33 -0700 (PDT) Message-Id: <199808230743.AAA20430@silvia.hip.berkeley.edu> To: ac199@hwcn.org CC: vanilla@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: (message from Tim Vanderhoek on Sat, 22 Aug 1998 21:45:08 -0400 (EDT)) Subject: Re: cvs commit: ports/devel/p5-Term-Query p5-Term-Query-2.0.tgz From: asami@FreeBSD.org (Satoshi Asami) Sender: owner-cvs-all@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk * Well, at least it was small... :) And amazing nobody noticed it for 3 months. ;) * Also, a general warning: If you are importing a port that * defines NO_WKRDIR, you must now also remember to delete the file * PLIST.mktmp before importing. Are you sure? :) === .if !target(clean) clean: pre-clean .if !defined(NOCLEANDEPENDS) @${MAKE} clean-depends .endif @${ECHO_MSG} "===> Cleaning for ${PKGNAME}" .if !defined(NO_WRKDIR) @if [ -d ${WRKDIR} ]; then \ if [ -w ${WRKDIR} ]; then \ ${RM} -rf ${WRKDIR}; \ else \ ${ECHO_MSG} "===> ${WRKDIR} not writable, skipping"; \ fi; \ fi .else @${RM} -f ${WRKDIR}/.*_done ${TMPPLIST} .endif .endif === Speaking of NO_WRKDIR, I'm thinking about removing it. I just don't feel good writing to the current directory. What do you guys think about changing bsd.port.mk to always create ${WRKDIR} (${.CURDIR}/work) in extract? Even if it's only for cookies, I think that's much cleaner. Satoshi