From owner-svn-src-user@FreeBSD.ORG Sun Oct 21 23:51:45 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CE5E7D02; Sun, 21 Oct 2012 23:51:45 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id E22478FC22; Sun, 21 Oct 2012 23:51:44 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id b5so1685077lbd.13 for ; Sun, 21 Oct 2012 16:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=4s0qitHgWMgMK51doIApq/ki6NFRcQoauvn2ZLq+Xng=; b=Sk0a0d7nslg57iRyZc6jfnrECt1Fqks2WcRtgSa1uf8YkbY4AYiDdvxOaN6Zrd622+ CADUOga+F9lxZ6NEQ+cVIJCtzQ1dH6m2UxNvgMAZZU4kdxKLxdv1CHXC2i1jm1Id7hft e/JpgnrNsdCyKDlrwLX6FZx3Q4dCtMBsIZDIz7lbifeRLjhaHR3KbLMLwF6hB1i9O21c wxBrLYRM1awOUOtGZmdwHejvcgG5DbPpl6ZUkhIHmJAJMCaYMjGCBBvc7gzdXqKDZkO6 bLkjYl/A8WFqXm1DU/mUEtMD/qiViuMoomkQQFF1RvaCGaR1Y7ICdJasqPUwKKTVsAs1 wxcQ== MIME-Version: 1.0 Received: by 10.152.129.197 with SMTP id ny5mr4345317lab.43.1350863503734; Sun, 21 Oct 2012 16:51:43 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.30.37 with HTTP; Sun, 21 Oct 2012 16:51:43 -0700 (PDT) In-Reply-To: <50847B60.3080108@freebsd.org> References: <201210211152.q9LBqGZc066660@svn.freebsd.org> <50847B60.3080108@freebsd.org> Date: Mon, 22 Oct 2012 00:51:43 +0100 X-Google-Sender-Auth: AyxAgH7XS08B_VBUkY05ZN-cPy0 Message-ID: Subject: Re: svn commit: r241805 - in user/andre/tcp_workqueue/sys: kern sys From: Attilio Rao To: Andre Oppermann Content-Type: text/plain; charset=UTF-8 Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2012 23:51:45 -0000 On Sun, Oct 21, 2012 at 11:46 PM, Andre Oppermann wrote: > On 21.10.2012 16:24, Attilio Rao wrote: >> >> On Sun, Oct 21, 2012 at 12:52 PM, Andre Oppermann >> wrote: >>> >>> Author: andre >>> Date: Sun Oct 21 11:52:16 2012 >>> New Revision: 241805 >>> URL: http://svn.freebsd.org/changeset/base/241805 >>> >>> Log: >>> Add MTX_DEF_SYSINIT() macro which combines defining a global mutex >>> with initializing it and ensuring the cache line alignment. >> >> >> If you really want such api (I'm not entirely sure i like it because >> it could lead to less readability in my opinion), can I suggest that >> you also unify the behaviour with other current kernel users? This way >> we have at least a defined and clear policy (and also that you submit >> it before to merge in -CURRENT the workqueue branch). > > > See r241815 for first batch. :) Cool, thanks. Please merge this whole patch alone. Attilio -- Peace can only be achieved by understanding - A. Einstein