Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Oct 2012 00:51:43 +0100
From:      Attilio Rao <attilio@freebsd.org>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r241805 - in user/andre/tcp_workqueue/sys: kern sys
Message-ID:  <CAJ-FndAGEMmNnEzp1572N-wF-z5BWBUozgsk0Zam-_sgbPThnQ@mail.gmail.com>
In-Reply-To: <50847B60.3080108@freebsd.org>
References:  <201210211152.q9LBqGZc066660@svn.freebsd.org> <CAJ-FndDSwssGF7TqhXYy=vi1cTLZrPbJB=CRFHmkj%2Bdd=XgT5g@mail.gmail.com> <50847B60.3080108@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 21, 2012 at 11:46 PM, Andre Oppermann <andre@freebsd.org> wrote:
> On 21.10.2012 16:24, Attilio Rao wrote:
>>
>> On Sun, Oct 21, 2012 at 12:52 PM, Andre Oppermann <andre@freebsd.org>
>> wrote:
>>>
>>> Author: andre
>>> Date: Sun Oct 21 11:52:16 2012
>>> New Revision: 241805
>>> URL: http://svn.freebsd.org/changeset/base/241805
>>>
>>> Log:
>>>    Add MTX_DEF_SYSINIT() macro which combines defining a global mutex
>>>    with initializing it and ensuring the cache line alignment.
>>
>>
>> If you really want such api (I'm not entirely sure i like it because
>> it could lead to less readability in my opinion), can I suggest that
>> you also unify the behaviour with other current kernel users? This way
>> we have at least a defined and clear policy (and also that you submit
>> it before to merge in -CURRENT the workqueue branch).
>
>
> See r241815 for first batch. :)

Cool, thanks.

Please merge this whole patch alone.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndAGEMmNnEzp1572N-wF-z5BWBUozgsk0Zam-_sgbPThnQ>