Date: Fri, 19 Nov 2004 10:10:27 GMT From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/72933: [patch] promisc mode on vlan interface does not work correctly Message-ID: <200411191010.iAJAARf0051334@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/72933; it has been noted by GNATS. From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-gnats-submit@FreeBSD.org, blackv@netroad.ru Cc: Subject: Re: kern/72933: [patch] promisc mode on vlan interface does not work correctly Date: Fri, 19 Nov 2004 13:05:04 +0300 Hi there, While the fix you proposed looks really reasonable, I cannot see how it helps in your particular case. If you look at the code, you'll see that the first conditional there is !BDG_ACTIVE(ifp), which isn't true in your setting. Any ideas? By the way, would you mind using context or unified diff format? Telling "change file bar.c line number X to FOO" isn't a good way of sending patches since it isn't robust to other changes that may have happened to the source file in the meantime. Moreover, the said format gives context to discuss the code in while your way doesn't. Thanks. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411191010.iAJAARf0051334>