From owner-svn-src-all@FreeBSD.ORG Tue Sep 9 10:47:37 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C3ABEA4D; Tue, 9 Sep 2014 10:47:37 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 40E28304; Tue, 9 Sep 2014 10:47:36 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s89AlYlf044606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 9 Sep 2014 14:47:34 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s89AlYK6044605; Tue, 9 Sep 2014 14:47:34 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 9 Sep 2014 14:47:34 +0400 From: Gleb Smirnoff To: Luigi Rizzo Subject: Re: svn commit: r270874 - in head/sys: dev/netmap net Message-ID: <20140909104734.GD17059@FreeBSD.org> References: <201408311133.s7VBXJlv084881@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 10:47:37 -0000 Luigi, On Mon, Sep 08, 2014 at 01:18:44PM +0200, Luigi Rizzo wrote: L> I would appreciate if you and others could inform me _before_ touching L> netmap-related stuff, and also, if you make changes make sure they are L> visible to the preprocessor so i can use conditional compilations. L> L> This is because this code is supposed to be the same on various FreeBSD L> revisions L> and Linux, and if each platform randomly changes its structures maintainance L> becomes very hard The patch was checked in to fix compilation failure, thus review was skipped. Does the patch itself have any problems with visibility to preprocessor? -- Totus tuus, Glebius.