From owner-freebsd-hackers  Tue Mar 28 10:04:27 1995
Return-Path: hackers-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA22754 for hackers-outgoing; Tue, 28 Mar 1995 10:04:27 -0800
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id KAA22748 for <hackers@freebsd.org>; Tue, 28 Mar 1995 10:04:21 -0800
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id EAA30784; Wed, 29 Mar 1995 04:01:15 +1000
Date: Wed, 29 Mar 1995 04:01:15 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199503281801.EAA30784@godzilla.zeta.org.au>
To: bde@zeta.org.au, charnier@lirmm.fr
Subject: Re: patches for -Wall in sbin
Cc: hackers@FreeBSD.org
Sender: hackers-owner@FreeBSD.org
Precedence: bulk

>>Let me handle the patches for fsck.  I have been (slowly) checking
>>phk's patches for -Wall for it.
>>

>That code uses functions for writing warning and errors messages, that
>-Wall doesn't like. What a pity to not use the 4.4 interface for this
>(warnx, errx and al.).

There should be warnings for bad args to warnx, etc. too :-).  Anything
that supports printf-style error messages should be declared as
__attribute__((format(printf, m, n))) where `m' is the arg number of
the format string and `n' is the arg number of the first vararg.

Bruce