Date: Thu, 04 Sep 2008 12:53:53 -0700 From: Julian Elischer <julian@elischer.org> To: Brooks Davis <brooks@freebsd.org> Cc: FreeBSD virtualization mailing list <freebsd-virtualization@freebsd.org> Subject: Re: next vimage commit.. a comment Message-ID: <48C03CD1.3010908@elischer.org> In-Reply-To: <20080904195031.GB4117@lor.one-eyed-alien.net> References: <48C03A8B.4050607@elischer.org> <20080904195031.GB4117@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis wrote:
> On Thu, Sep 04, 2008 at 12:44:11PM -0700, Julian Elischer wrote:
>> Some have suggested that we change the VNET_ITERLOOP_BEGIN() /
>> VNET_ITERLOOP_END() code,
>> and thinking about this I suggest that we go straight for the
>> final solution of:
>>
>> change:
>> code
>> code
>> code
>>
>> to:
>>
>> FOREACH_VNET(VINET, vnet_inet) {
>> code
>> code
>> code
>> }
>>
>> straight away. and get it over and done with...
>>
>> anyone have thoughts?
>
> I agree. We should avoid committing new code we plan to rip up later.
>
> -- Brooks
Ok well it's going to massively expand the size of this commit diff
but if we are convinced that we will "understand" that it does nothing
(yet) then we can still review it for "no binary changes" relatively
easily once this happens..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48C03CD1.3010908>