Date: Tue, 14 Jul 2015 13:32:20 +0200 From: Ed Schouten <ed@nuxi.nl> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Ed Schouten <ed@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285404 - head/sys/compat/cloudabi Message-ID: <CABh_MKm3NHs9gyJ36uUCrGbNEnLjRzFZEK7fSc8GAAN5mEzo9Q@mail.gmail.com> In-Reply-To: <20150714110126.GV2404@kib.kiev.ua> References: <201507111941.t6BJfV1a072539@repo.freebsd.org> <20150711194732.GB2404@kib.kiev.ua> <CABh_MK=wtpr-zn3N8dV5k7UnVNjv1XZ9ikdmVi8sg-faVr4jQA@mail.gmail.com> <20150711205611.GC2404@kib.kiev.ua> <CABh_MK=dop1WHCUYz=2rStbVusC9wKONsH%2BrN-oAaZc8sQ93zA@mail.gmail.com> <20150714110126.GV2404@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Kostik, > Exactly. I think that for programs that are built around pipelines, > where a series of processes have stdin/stdout attached, having > something like SIGPIPE makes sense. So far the focus It looks like I accidentally truncated the last sentence. Sorry about that. "So far the focus with CloudABI is on running services, in which stdin/stdout typically don't play a role." 2015-07-14 13:01 GMT+02:00 Konstantin Belousov <kostikbel@gmail.com>: > On Tue, Jul 14, 2015 at 12:22:51PM +0200, Ed Schouten wrote: >> Ah, okay. Now I think I understand what you're hinting at. So your >> proposal is to let cloudabi_sys_proc_raise() only call into >> sys_kill(), nothing else. We then reset all signals to their default >> behavior at some point during process startup. >> >> Let me address this by the time I'm sending out the CloudABI sysentvec >> for review, as that would be the place where I'd need to do that. I'll >> remove the call to kern_sigaction() in the meantime. Does that sound >> all right? > > Sounds fine. But, I do not recomment to use sys_kill(), which is > the FreeBSD syscall implementation. You should use pksignal(9) or > similar function directly, IMO. Minor code duplication to create > proper ksiginfo is not critical, while you do not need pfind() or > complications with negative pid values. That sounds like a good idea. I just sent you a code review: https://reviews.freebsd.org/D3076 Thanks for your time! -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK/VAT number: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKm3NHs9gyJ36uUCrGbNEnLjRzFZEK7fSc8GAAN5mEzo9Q>