From owner-freebsd-arch Wed Sep 18 11:48:25 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35E2537B401 for ; Wed, 18 Sep 2002 11:48:24 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B17A43E65 for ; Wed, 18 Sep 2002 11:48:23 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8IImLtF005975; Wed, 18 Sep 2002 20:48:22 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "Andrew R. Reiter" Cc: arch@FreeBSD.ORG Subject: Re: Trivial mbuf patch for review. In-Reply-To: Your message of "Wed, 18 Sep 2002 14:30:44 EDT." Date: Wed, 18 Sep 2002 20:48:21 +0200 Message-ID: <5974.1032374901@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , "And rew R. Reiter" writes: > >The only comment I have is the same one I mentioned on irc (I guess it was >more in the form of a question) -- but for the record... > >Should m_length() return unsigned? Also, if not, should we fix below in >bpf.c where pktlen is unsigned? I've changed it to unsigned with no ill effects. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message