From owner-freebsd-current@FreeBSD.ORG Thu Sep 7 20:24:04 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1AA116A4E6 for ; Thu, 7 Sep 2006 20:24:04 +0000 (UTC) (envelope-from ambrisko@ambrisko.com) Received: from mail.ambrisko.com (mail.ambrisko.com [64.174.51.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id A617F43D72 for ; Thu, 7 Sep 2006 20:23:55 +0000 (GMT) (envelope-from ambrisko@ambrisko.com) Received: from server2.ambrisko.com (HELO www.ambrisko.com) ([192.168.1.2]) by mail.ambrisko.com with ESMTP; 07 Sep 2006 13:21:20 -0700 Received: from ambrisko.com (localhost [127.0.0.1]) by www.ambrisko.com (8.13.1/8.12.11) with ESMTP id k87KNsg0040570; Thu, 7 Sep 2006 13:23:54 -0700 (PDT) (envelope-from ambrisko@ambrisko.com) Received: (from ambrisko@localhost) by ambrisko.com (8.13.1/8.13.1/Submit) id k87KNsmR040569; Thu, 7 Sep 2006 13:23:54 -0700 (PDT) (envelope-from ambrisko) From: Doug Ambrisko Message-Id: <200609072023.k87KNsmR040569@ambrisko.com> In-Reply-To: <45006870.4070403@elischer.org> To: Julian Elischer Date: Thu, 7 Sep 2006 13:23:54 -0700 (PDT) X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Cc: freebsd-current@freebsd.org Subject: Re: bge IPMI patch final review X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2006 20:24:04 -0000 Julian Elischer writes: | Doug Ambrisko wrote: | | >I'd like to commit my final bge version of the IPMI patch to keep IPMI | >working when FreeBSD attaches and also when the NIC is downed. | >I also have patches for the bce to do the same that I sent to David. | >This has various reviews and testing in the wild. I want to give | >a heads up since there have been changes in the bge driver recently. | >I'd like to not hold off on this anymore. | | code looks good but could you add a bunch of comments explaining the | handshake and how this works. (be verbose please) You tell me and we'll both know :-( It's inspired from Linux and that doesn't explain it. Their doc. doesn't say much except do this then don't touch the PHY which is what Linux does. Via emperical evidence I found that if I was careful I could talk to the PHY initially. Now if you want a more interesting thing to look at then try the bce version. There is absolutely no doc's. that I could find. About the only thing I can say is that we have to play with is the BGE_MODECTL_STACKUP that says the OS driver is running. I could mention that. If we really had insight into a potential firmware handshake then we could try to co-operate and access the PHY in a safe way to watch link state changes. Via emperical means I could not figure anything out :-( It's even worse that we can't tell if IPMI was actually enabled or not since some implementations required a reset before talking to the chip to see what it was doing :-( I don't see any clues in the kernel.org or BroadCom's driver. Currently it does more then what Linux and Solaris do :-) Doug A.