Date: Sun, 4 Aug 2002 06:35:34 -0400 (EDT) From: Jeff Roberson <jroberson@chesapeake.net> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/alpha/osf1 imgact_osf1.c src/sys/coda coda_namecache.c coda_subr.c coda_vfsops.c src/sys/compat/linux linux_getcwd.c linux_misc.c src/sys/compat/pecoff imgact_pecof Message-ID: <20020804063147.V86323-100000@mail.chesapeake.net> In-Reply-To: <200208041029.g74ATbxl096810@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 4 Aug 2002, Jeff Roberson wrote: > jeff 2002/08/04 03:29:37 PDT > > Log: > - Replace v_flag with v_iflag and v_vflag > - v_vflag is protected by the vnode lock and is used when synchronization > with VOP calls is needed. > - v_iflag is protected by interlock and is used for dealing with vnode > management issues. These flags include X/O LOCK, FREE, DOOMED, etc. > - All accesses to v_iflag and v_vflag have either been locked or marked with > mp_fixme's. > - Many ASSERT_VOP_LOCKED calls have been added where the locking was not > clear. > - Many functions in vfs_subr.c were restructured to provide for stronger > locking. > > Idea stolen from: BSD/OS > There is one lock order violation that I want to fix in a seperate commit. It is with the vnode free list mutex. I wanted to keep this commit as mechanical as possible so I wouldn't lose context in the cvs logs. For filesystems that I do not have access to I kept my commits as minimal as possible even where I saw problems. I put in asserts where I felt there may be missing locks. Or where it wasn't very easy to see that the DEBUG_VFS_LOCKS code would not catch it. If I broke your favorite filesystem let me know and I apologize. Thanks, Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020804063147.V86323-100000>