Date: Tue, 2 Dec 2008 17:15:00 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Sam Leffler <sam@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Paul Saab <ps@freebsd.org> Subject: Re: svn commit: r185544 - head/sys/modules/ae Message-ID: <20081202170528.S80401@maildrop.int.zabbadoz.net> In-Reply-To: <493568EE.20609@freebsd.org> References: <200812020445.mB24jXaS048636@svn.freebsd.org> <20081202064345.S80401@maildrop.int.zabbadoz.net> <493568EE.20609@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2 Dec 2008, Sam Leffler wrote: Hi, > Bjoern A. Zeeb wrote: >> On Tue, 2 Dec 2008, Paul Saab wrote: >> >>> Author: ps >>> Date: Tue Dec 2 04:45:33 2008 >>> New Revision: 185544 >>> URL: http://svn.freebsd.org/changeset/base/185544 >>> >>> Log: >>> Fix world by including opt_route.h >> >> Where did world fail for you? >> >> I assume what failed was a single direct module build? Per discussion >> on current@ we are working on this but it's a long list of files with >> awkward dependencies to go through. >> >> If that was the only problem, the manual module build, please let me >> know so I can back this out again as soon as the vimage header files >> are untangled. > Note I added explicit opt_route.h to all the ath-related modules because I > hit problems too. I must've missed the discussion on current@. No problem and thanks for the note. I have removed them all and then readded the ones still (really) needed. The universe that is currently building doesn't have them in ath*/Makefiles and ae/Makefile anymore. Did a make depend in sys/modules/ and after the initial untangling we are down from ~390 to 14 modules still inlcuding vnet.h and thus depending on opt_route.h A veriosn of the patch is here: http://people.freebsd.org/~bz/20081202-v-h-06.diff There is more cleanup to follow afterwards. I also found quite a few other spots going through more >100 files... but that's initally unrelated and in my general "INET cleanup" pigeonhole. /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081202170528.S80401>