From owner-cvs-all  Thu Jan  4  5:28: 9 2001
From owner-cvs-all@FreeBSD.ORG  Thu Jan  4 05:28:06 2001
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4BBC037B400; Thu,  4 Jan 2001 05:28:05 -0800 (PST)
Received: (from des@localhost)
	by flood.ping.uio.no (8.9.3/8.9.3) id OAA74877;
	Thu, 4 Jan 2001 14:28:03 +0100 (CET)
	(envelope-from des@ofug.org)
Sender: des@ofug.org
X-URL: http://www.ofug.org/~des/
X-Disclaimer: The views expressed in this message do not necessarily
  coincide with those of any organisation or company with
  which I am or have been affiliated.
To: Paul Richards <paul@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl
References: <200012300014.eBU0E1238805@freefall.freebsd.org>
From: Dag-Erling Smorgrav <des@ofug.org>
Date: 04 Jan 2001 14:28:02 +0100
In-Reply-To: Paul Richards's message of "Fri, 29 Dec 2000 16:14:01 -0800 (PST)"
Message-ID: <xzp8zorla59.fsf@flood.ping.uio.no>
Lines: 11
User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Paul Richards <paul@FreeBSD.org> writes:
>   Log:
>   Change open modes from ">$file" to "> $file" because it's much safer should
>   $file not be what you expect, particularly should $file turn out to be
>   "+REQUIRES" since ">+" is a valid open mode.

This would not be a problem if you used sysopen() instead of open().

DES
-- 
Dag-Erling Smorgrav - des@ofug.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message