From owner-freebsd-ports@FreeBSD.ORG Fri Jan 23 04:39:44 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D6D716A4CE for ; Fri, 23 Jan 2004 04:39:44 -0800 (PST) Received: from smtp.infracaninophile.co.uk (happy-idiot-talk.infracaninophile.co.uk [81.2.69.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DD7543D39 for ; Fri, 23 Jan 2004 04:39:41 -0800 (PST) (envelope-from m.seaman@infracaninophile.co.uk) Received: from happy-idiot-talk.infracaninophile.co.uk (localhost [IPv6:::1]) i0NCdPse049313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Jan 2004 12:39:25 GMT (envelope-from matthew@happy-idiot-talk.infracaninophile.co.uk) Received: (from matthew@localhost)id i0NCdOqm049312; Fri, 23 Jan 2004 12:39:24 GMT (envelope-from matthew) Date: Fri, 23 Jan 2004 12:39:24 +0000 From: Matthew Seaman To: Sepherosa Ziehau Message-ID: <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1i X-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00 autolearn=no version=2.62 X-Spam-Checker-Version: SpamAssassin 2.62 (2004-01-11) on happy-idiot-talk.infracaninophile.co.uk cc: ports@freebsd.org Subject: Re: FreeBSD Port: jfreechart-0.9.13 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2004 12:39:44 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote: > without a java document, a java library is useless. I have upgraded=20 > jfreechart to 0.9.16 and add javadoc support. > Hope somebody can review it and commit it for me. Nice work. However, I can see a couple of problems with your patch. You're building javadocs with one of a number of possible JDKs, and that has the unfortunate consequence that the plist for the generated Javadocs is different for different JDK versions. You're also using ant(1) to do the build, which overrides the settings obtained by USE_JAVA=3Dx.y and instead uses whatever the default JDK on the system is. (Normally those JDKs will be the same, but not always.) You can easily solve the pkg-plist problem by use of the PORTDOCS make variable -- which also has the handy side effect of keeping the pkg-plist file for the port nice and short. See the databases/mysql-connector-java port I maintain for an example. You can (if you think it's necessary) solve the ant(1) version problem by: ANT=3D ${SETENV} JAVA_HOME=3D${JAVA_HOME} ant You also need a BUILD_DEPENDS on the devel/apache-ant port. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 26 The Paddocks Savill Way PGP: http://www.infracaninophile.co.uk/pgpkey Marlow Tel: +44 1628 476614 Bucks., SL7 1TH UK --envbJBWh7q8WU6mo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAERX8dtESqEQa7a0RAgEJAJ9eN5MKvEi2ZUgOljyzyrrzagaFIwCfQZ0l 808S2EWTWDEJGd3qlq09Njs= =lGNq -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--