From owner-freebsd-current@FreeBSD.ORG Tue May 22 18:54:21 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 51A8716A421 for ; Tue, 22 May 2007 18:54:21 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.177]) by mx1.freebsd.org (Postfix) with ESMTP id 3A3D813C468 for ; Tue, 22 May 2007 18:54:21 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (smtpin08-en2 [10.13.10.153]) by smtpout.mac.com (Xserve/smtpout07/MantshX 4.0) with ESMTP id l4MIBQlr014394; Tue, 22 May 2007 11:11:26 -0700 (PDT) Received: from [172.24.104.227] (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mac.com (Xserve/smtpin08/MantshX 4.0) with ESMTP id l4MIB0RH022325 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 22 May 2007 11:11:07 -0700 (PDT) In-Reply-To: <"63182.2001:6f8:101e:0:20e:cff:fe6d:6adb.1179830426.squirrel"@webmail.alpha-tierchen.de> References: <"63182.2001:6f8:101e:0:20e:cff:fe6d:6adb.1179830426.squirrel"@webmail.alpha-tierchen.de> Mime-Version: 1.0 (Apple Message framework v752.3) X-Priority: 3 (Normal) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Message-Id: <8869FB6B-5FF0-4414-8636-8CACE5FD6684@mac.com> Content-Transfer-Encoding: quoted-printable From: Marcel Moolenaar Date: Tue, 22 May 2007 14:10:51 -0400 To: =?ISO-8859-1?Q?Bj=F6rn_K=F6nig?= X-Mailer: Apple Mail (2.752.3) X-Brightmail-Tracker: AAAAAA== X-Brightmail-scanned: yes Cc: current@freebsd.org Subject: Re: sysinstall says "BARF", concerns libdisk and geom_label X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 18:54:21 -0000 On May 22, 2007, at 6:40 AM, Bj=F6rn K=F6nig wrote: > Hello, > > when I start sysinstall I get the error message "BARF 148 <88>". The > reason for this is the label of my Windows partion, it is called =20 > "Windows > XP" and contains a space character. libdisk/open_disk.c needs to =20 > parse the > value of kern.geom.conftxt which contains spaces as field seperator, > therefore it fails. > > A quick and dirty workaround would be to skip labels that contain =20 > space > characters, which can be easily done in g_label_is_name_ok > (sys/geom/label/g_label.c). > > But I am looking for a better solution. So it might be more =20 > accurate to > revise libdisk, i.e. improve the parsing of kern.geom.conftxt. > > Maybe the best but most time-consuming solution is to change the =20 > output of > kern.geom.conftxt to another format, e.g. XML. > > Are there any comments or other suggestions? The major flaw in libdisk is that each platform has its own set of supported partitioning schemes. With other efforts underway, we need to stop doing that. I would suggest to stop using libdisk entirely and instead work on sysinstall to support partitioning disks based on gpart. That way every platform can (potentially) create disks with every partitioning scheme that freebsd supports. --=20 Marcel Moolenaar xcllnt@mac.com