From owner-svn-src-all@FreeBSD.ORG Mon May 28 21:04:59 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1524E106566C; Mon, 28 May 2012 21:04:59 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id BFA998FC0A; Mon, 28 May 2012 21:04:58 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:4c1c:92fb:538c:83ed] (unknown [IPv6:2001:7b8:3a7:0:4c1c:92fb:538c:83ed]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id EE9875C59; Mon, 28 May 2012 23:04:57 +0200 (CEST) Message-ID: <4FC3E876.2050504@FreeBSD.org> Date: Mon, 28 May 2012 23:04:54 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120522 Thunderbird/13.0 MIME-Version: 1.0 To: David Chisnall References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120527203100.GA22921@freebsd.org> <4FC3D320.1070709@FreeBSD.org> <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> In-Reply-To: <944B5ADD-8F3C-4CE4-BF97-36964F4EBB64@theravensnest.org> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, Roman Divacky , src-committers@FreeBSD.org, Konstantin Belousov , svn-src-all@FreeBSD.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2012 21:04:59 -0000 On 2012-05-28 22:17, David Chisnall wrote: > On 28 May 2012, at 20:33, Dimitry Andric wrote: >> On the other hand, it's really platform-dependent: I've checked several >> Linux distributions, and it is fairly unpredictable whether their gcc >> passes --hash-style to the linker, or if they do, which option they use. > > Can we make it dependent on the triple? i.e. if the triple is arch-whatever-freebsd9 or greater, make it pass the flag, otherwise don't bother? Or is it not worth caring about older FreeBSD? There's no real disadvantage in passing it unconditionally (marginally longer link times) and potentially a big benefit. We only ship clang in FreeBSD 9 or later, so in our own copy it can be unconditional. FreeBSD 8 and earlier still use ld 2.15, which doesn't support --hash-style. But to not inconvenience users of the clang port, it would be nice to pass it only for freebsd9 and later. > I don't see a problem with committing it upstream, but it would be nice to pull that change in locally before 9.1 and not have to wait for LLVM 3.2 before we got to make use of it. > > Misleading and poorly designed benchmarks on Phoronix are at stake! Sure, I'll commit this now, and merge it to stable/9 later.