From owner-svn-src-head@FreeBSD.ORG  Thu Sep 27 18:48:42 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7E951065670;
	Thu, 27 Sep 2012 18:48:42 +0000 (UTC) (envelope-from ken@kdm.org)
Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A24C8FC19;
	Thu, 27 Sep 2012 18:48:42 +0000 (UTC)
Received: from nargothrond.kdm.org (localhost [127.0.0.1])
	by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id q8RImaN9087405;
	Thu, 27 Sep 2012 12:48:36 -0600 (MDT)
	(envelope-from ken@nargothrond.kdm.org)
Received: (from ken@localhost)
	by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id q8RIma0Q087404;
	Thu, 27 Sep 2012 12:48:36 -0600 (MDT) (envelope-from ken)
Date: Thu, 27 Sep 2012 12:48:36 -0600
From: "Kenneth D. Merry" <ken@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20120927184836.GA87386@nargothrond.kdm.org>
References: <201209221241.q8MCfnhJ067937@svn.freebsd.org>
	<20120925233712.GA26920@nargothrond.kdm.org>
	<20120926072005.GH1391@garage.freebsd.pl>
	<20120926172917.GA71268@nargothrond.kdm.org>
	<20120926185339.GA1402@garage.freebsd.pl>
	<20120926192117.GA89741@nargothrond.kdm.org>
	<20120926194541.GB1402@garage.freebsd.pl>
	<20120927181624.GX1402@garage.freebsd.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120927181624.GX1402@garage.freebsd.pl>
User-Agent: Mutt/1.4.2i
Cc: svn-src-head@FreeBSD.org, jdp@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, phk@FreeBSD.org
Subject: Re: svn commit: r240822 - head/sys/geom
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2012 18:48:42 -0000

On Thu, Sep 27, 2012 at 20:16:25 +0200, Pawel Jakub Dawidek wrote:
> On Wed, Sep 26, 2012 at 09:45:41PM +0200, Pawel Jakub Dawidek wrote:
> > On Wed, Sep 26, 2012 at 01:21:17PM -0600, Kenneth D. Merry wrote:
> > > Ahh.  How about using LIST_FOREACH_SAFE?  Would that address the problem at
> > > hand?  Are there any other races in there?
> > 
> > It depends. If one geom can hold more than one provider then it might be
> > racy, but from what I see there is always only one provider - there has
> > to be only one, because disk_destroy() destroys it and struct disk
> > represents always only one disk. If that's true then I see not reason to
> > have a loop in there. I'd change it to:
> > 
> > void
> > disk_gone(struct disk *dp)
> > {
> > 	struct g_geom *gp;
> > 	struct g_provider *pp;
> > 
> > 	gp = dp->d_geom;
> > 	if (gp != NULL) {
> > 		pp = LIST_FIRST(&gp->provider);
> > 		if (pp != NULL)
> > 			g_wither_provider(pp, ENXIO);
> > 	}
> > }
> 
> Final patch for review:
> 
> 	http://people.freebsd.org/~pjd/patches/geom_disk.c.3.patch

Looks good, thanks!

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG