From owner-cvs-src@FreeBSD.ORG Wed Dec 15 15:47:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65F5716A4CE; Wed, 15 Dec 2004 15:47:34 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A86D43D46; Wed, 15 Dec 2004 15:47:33 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBFFlVii027136; Wed, 15 Dec 2004 17:47:31 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 70449-01; Wed, 15 Dec 2004 17:47:30 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBFFlUvi027133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 15 Dec 2004 17:47:30 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iBFFlXgh096022; Wed, 15 Dec 2004 17:47:33 +0200 (EET) (envelope-from ru) Date: Wed, 15 Dec 2004 17:47:33 +0200 From: Ruslan Ermilov To: Tom Rhodes Message-ID: <20041215154733.GB85290@ip.net.ua> References: <200412150210.iBF2AodY094280@repoman.freebsd.org> <20041215084901.GC25967@ip.net.ua> <20041215083548.5455ea2c@localhost> <20041215135230.GA2319@ip.net.ua> <20041215090139.53a90960@localhost> <20041215142114.GA24846@ip.net.ua> <20041215095848.658d4cc6@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw" Content-Disposition: inline In-Reply-To: <20041215095848.658d4cc6@localhost> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2004 15:47:34 -0000 --tjCHc7DPkfUGtrlw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tom, On Wed, Dec 15, 2004 at 09:58:48AM -0500, Tom Rhodes wrote: > So, your saying that in revision 1.238 it was "ok" for you to > "break existing style" without documenting it in the commit > log: >=20 > "For variables that are only checked with defined(), don't provide > any fake value." >=20 > But not ok for me to "break existing sytle" in revision 1.241 > which returned the style back to what we had for at least 2-3 > years? (Note, my time of 2-3 years may be off, it's just a > guess from since I've had my commit bit). >=20 My bad that I didn't put it into the commit log. I even remember thinking about splitting the style/change thing between two commits, but then given up on the idea and just went ahead and committed it in a single revision. My excuse for that being: this commit covered a zillion of other files (see commitlogs/share.20041201.gz). > > see any controversy between these two revisions (rev. 1.211 and > > the upcoming revision when you commit my patch ;), both use the > > rule "don't break an existing style". >=20 > There is no real "controversy" over revisions. I just don't > particularly fancy being told to do something on one commit > and then get told I did almost the same thing wrong in another > commit. >=20 Sorry about that, but some facts just don't hold forever. ;) > I agree with you that variables for ppp(8) should be placed in > their own specific area; >=20 Also because that "NO" area is for documenting knobs that affect *not* building some parts of the world. In case of ppp(8), the knobs only tell how to *not* build parts of ppp(8). If there were NO_PPP, it would belong to this section indeed. > however, the style thing I'm a bit > leary on. Also, please take note that if I'm coming off as an > asshole, I don't mean to be. I'm just concerned about how this > may play out. >=20 OK, how about just committing my patch, now that you have all explanations in hands. Feel free to attribute your confusion to me. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --tjCHc7DPkfUGtrlw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwFyVqRfpzJluFF4RAtLvAJ9LQza2WYKouhPh+aFy9YS4Ys6b7QCfbhzD ZtYpETUWP2/ziDps9pTNXXU= =4dta -----END PGP SIGNATURE----- --tjCHc7DPkfUGtrlw--