From owner-cvs-all Wed Jul 18 18:31:48 2001 Delivered-To: cvs-all@freebsd.org Received: from assaris.sics.se (dhcp-221-142.pdc.kth.se [130.237.221.142]) by hub.freebsd.org (Postfix) with ESMTP id 5CB6637B403; Wed, 18 Jul 2001 18:31:42 -0700 (PDT) (envelope-from assar@assaris.sics.se) Received: (from assar@localhost) by assaris.sics.se (8.9.3/8.9.3) id DAA69025; Thu, 19 Jul 2001 03:31:58 +0200 (CEST) (envelope-from assar) To: Greg Lehey Cc: Dag-Erling Smorgrav , Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys sbuf.h References: <200107181558.f6IFw6A86129@freefall.freebsd.org> <20010719104216.S69861@wantadilla.lemis.com> From: Assar Westerlund Date: 19 Jul 2001 03:31:55 +0200 In-Reply-To: Greg Lehey's message of "Thu, 19 Jul 2001 10:42:16 +0930" Message-ID: <5l66cpwvp0.fsf@assaris.sics.se> Lines: 16 User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Greg Lehey writes: > On Wednesday, 18 July 2001 at 21:29:56 +0200, Dag-Erling Smorgrav wrote: > > Poul-Henning Kamp writes: > >> Log: > >> Add printf format checking to sbuf_printf() > > > > Big style boo-boo, the prototype for sbuf_printf() is now 86 > > characters wide. > > Isn't this also a gcc extension? I thought that was not desired. No. __printflike is #define'd differently in sys/cdefs.h for (modern) gcc and other compilers. It's most definitely desired since it provides useful warnings. /assar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message