From owner-cvs-all@FreeBSD.ORG  Mon Jun 11 20:13:01 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EF7B916A468;
	Mon, 11 Jun 2007 20:13:01 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id C7A1B13C45D;
	Mon, 11 Jun 2007 20:13:01 +0000 (UTC) (envelope-from sam@errno.com)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l5BKD16S080374
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 11 Jun 2007 13:13:01 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <466DACD6.4040606@errno.com>
Date: Mon, 11 Jun 2007 13:13:10 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.0 (X11/20070530)
MIME-Version: 1.0
To: Andre Oppermann <andre@FreeBSD.org>
References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org>
In-Reply-To: <200706112008.l5BK8CQ7033543@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2007 20:13:02 -0000

Andre Oppermann wrote:
> andre       2007-06-11 20:08:12 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/net              if.h 
>   Log:
>   Add IFCAP_LRO flag for drivers to announce their TCP Large Receive Offload
>   capabilities.
>   
>   Revision  Changes    Path
>   1.108     +1 -0      src/sys/net/if.h
> http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108
> 
> 
There are many offload capabilities defined that are not well thought 
out.  In particular we do not distinguish between ipv4 and ipv6 for 
things like cksum and tso so there's no way to disable individual 
features.  The ability to tweak LRO is clearly needed and clearly belong 
as an ifnet capability but unilateraly deciding this is the wrong approach.

	Sam