From owner-cvs-all Tue May 7 16:23:29 2002 Delivered-To: cvs-all@freebsd.org Received: from isris.pair.com (isris.pair.com [209.68.2.39]) by hub.freebsd.org (Postfix) with SMTP id 3B79B37B405 for ; Tue, 7 May 2002 16:23:03 -0700 (PDT) Received: (qmail 51828 invoked by uid 3130); 7 May 2002 23:23:02 -0000 Date: Tue, 7 May 2002 19:23:01 -0400 From: Garrett Rooney To: Garance A Drosihn Cc: "J. Mallett" , John Baldwin , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/sed main.c sed.1 Message-ID: <20020507232301.GB45271@electricjellyfish.net> References: <20020507184519.GB28857@FreeBSD.ORG> <20020507191959.GA26441@FreeBSD.ORG> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.25i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, May 07, 2002 at 07:20:21PM -0400, Garance A Drosihn wrote: > >Various points taken. Tell me the preferred way to handle > >options which may or may not take arguments, and I'll give > >it my best shot. I'd assume it's to do something like > > > >case 'i': > > if (*argv[optind+1] != '-') { > > take the option from argv[optind++]; > > } else > > set a binary flag for -i, and don't set the extension. > > break; > > > >Does that seem right? > > We do not want options which "may or may not take arguments". > The standards only allow those as concessions to older code > which was written that way. I am pretty sure all "new code" > has options such that they either always take an argument, > or they never take an argument. it's all well and good to have interface guidelines like this, but in this particular case i think being compatable with a common idiom (the way perl treats -i) is more important than following the letter of the law. -garrett -- garrett rooney Remember, any design flaw you're rooneg@electricjellyfish.net sufficiently snide about becomes http://electricjellyfish.net/ a feature. -- Dan Sugalski To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message